From: Andrei Rybak <rybak.a.v@gmail.com>
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de, phillip.wood@dunelm.org.uk,
predatoramigo@gmail.com
Subject: [RFC PATCH v2 0/4] rebase --edit-todo --exec
Date: Wed, 20 Nov 2019 10:52:34 +0100 [thread overview]
Message-ID: <20191120095238.4349-1-rybak.a.v@gmail.com> (raw)
In-Reply-To: <20191114163549.7648-1-rybak.a.v@gmail.com>
Differences from v1:
- Added missing RFC marker.
- Fixed CC list.
- Addressed Junio's comment about masked variable in a for loop: another
preparatory patch is added.
- Cleaned up copy-pasted unused code in the new test.
----
Original cover letter:
I've wanted this feature for a long time, and now with rebase working without
forking rebase--interactive (thanks to Phillip Wood for working on that), I
finally got around to implementing it.
It still needs validation for arguments. Right now, I have two ideas:
1. iterate over original argv and make sure its just '--exec's with its
arguments.
2. check all other vars in options[].
Andrei Rybak (4):
builtin/rebase.c: reuse loop variable
rebase: prepare cmd before choosing action
rebase: extract add_exec()
rebase -i: allow --edit-todo with --exec
Documentation/git-rebase.txt | 3 +-
builtin/rebase.c | 63 +++++++++++++++++++++--------------
t/t3404-rebase-interactive.sh | 32 ++++++++++++++++++
3 files changed, 72 insertions(+), 26 deletions(-)
--
2.24.0.windows.2
next prev parent reply other threads:[~2019-11-20 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 16:35 [PATCH 0/3] rebase --edit-todo --exec Andrei Rybak
2019-11-14 16:35 ` [PATCH 1/3] rebase: prepare cmd before choosing action Andrei Rybak
2019-11-15 5:49 ` Junio C Hamano
2019-11-14 16:35 ` [PATCH 2/3] rebase: extract add_exec() Andrei Rybak
2019-11-14 16:35 ` [PATCH 3/3] rebase -i: allow --edit-todo with --exec Andrei Rybak
2019-11-20 9:52 ` Andrei Rybak [this message]
2019-11-20 9:52 ` [RFC PATCH v2 1/4] builtin/rebase.c: reuse loop variable Andrei Rybak
2019-11-21 1:30 ` Junio C Hamano
2019-11-20 9:52 ` [RFC PATCH v2 2/4] rebase: prepare cmd before choosing action Andrei Rybak
2019-11-21 2:00 ` Junio C Hamano
2019-11-22 19:08 ` Andrei Rybak
2019-11-20 9:52 ` [RFC PATCH v2 3/4] rebase: extract add_exec() Andrei Rybak
2019-11-20 9:52 ` [RFC PATCH v2 4/4] rebase -i: allow --edit-todo with --exec Andrei Rybak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120095238.4349-1-rybak.a.v@gmail.com \
--to=rybak.a.v@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=predatoramigo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).