From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
git@vger.kernel.org,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH 2/2] hex: drop sha1_to_hex()
Date: Tue, 12 Nov 2019 20:15:07 -0500 [thread overview]
Message-ID: <20191113011507.GC20431@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqbltgeg58.fsf@gitster-ct.c.googlers.com>
On Wed, Nov 13, 2019 at 10:09:23AM +0900, Junio C Hamano wrote:
> Yes. "binary hash" is about "unsigned char[]". I think that's
> historical accident---we added "struct object_id *" variants without
> updating the comment.
>
> Here is another try. The "everybody uses oid_to_hex" in the log
> message has also been updated.
This looks good to me (and thank you for cleaning up my messy commit
message).
> 1: 8a030f1796 ! 1: b19f3fe9dd hex: drop sha1_to_hex()
> @@ Metadata
> ## Commit message ##
> hex: drop sha1_to_hex()
>
> - There's only a single caller left of sha1_to_hex(), since everybody now
> - uses oid_to_hex() instead. This case is in the sha1dc wrapper, where we
> - print a hex sha1 when we find a collision. This one will always be sha1,
> - regardless of the current hash algorithm, so we can't use oid_to_hex()
> - here. In practice we'd probably not be running sha1 at all if it isn't
> - the current algorithm, but it's possible we might still occasionally
> + There's only a single caller left of sha1_to_hex(), since everybody
> + that has an object name in "unsigned char[]" now uses hash_to_hex()
> + instead.
That makes sense. I mentioned oid_to_hex() originally because most of
the callers _did_ switch from sha1_to_hex(oid->hash) to oid_to_hex(oid).
But that happened far enough in the past that the more interesting
change is using the generic hash_to_hex().
-Peff
next prev parent reply other threads:[~2019-11-13 1:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 9:03 [PATCH 0/2] getting rid of sha1_to_hex() Jeff King
2019-11-11 9:04 ` [PATCH 1/2] hex: drop sha1_to_hex_r() Jeff King
2019-11-11 18:30 ` Johannes Schindelin
2019-11-11 9:04 ` [PATCH 2/2] hex: drop sha1_to_hex() Jeff King
2019-11-11 14:18 ` SZEDER Gábor
2019-11-11 14:29 ` Jeff King
2019-11-12 4:13 ` Junio C Hamano
2019-11-12 10:57 ` Jeff King
2019-11-12 11:44 ` SZEDER Gábor
2019-11-12 12:12 ` Jeff King
2019-11-12 11:49 ` Junio C Hamano
2019-11-12 12:15 ` Jeff King
2019-11-13 1:09 ` Junio C Hamano
2019-11-13 1:15 ` Jeff King [this message]
2019-11-11 9:09 ` [PATCH 0/2] getting rid of sha1_to_hex() Junio C Hamano
2019-11-11 9:21 ` Jeff King
2019-11-11 23:53 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113011507.GC20431@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).