From: Emily Shaffer <emilyshaffer@google.com>
To: "Miriam R." <mirucam@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [Outreachy] First contribution
Date: Mon, 21 Oct 2019 11:35:19 -0700 [thread overview]
Message-ID: <20191021183519.GA139951@google.com> (raw)
In-Reply-To: <CAN7CjDCacSKzN8fXgUe4ejNqM+AAe1o7NaDaFgM5WcYYV0bQ9g@mail.gmail.com>
On Mon, Oct 21, 2019 at 12:39:16PM +0200, Miriam R. wrote:
> Dear Git developers,
> I’m an Outreachy applicant, I would like to make my contribution to
> apply to this Outreachy internship period.
Welcome, Miriam! Good to hear from you.
>
> I have found this issue tagged as open and goodfirstissue:
> https://github.com/gitgitgadget/git/issues/230
>
> But there is a PR from 4 months ago:
> https://github.com/gitgitgadget/git/pull/271 and I don't know how to
> find out if a patch including that change already exists or if it
> makes sense to do it.
GitGitGadget exists to repackage PRs (which Git project doesn't use)
into emailed patches (which Git project does use) when the author writes
/submit on the PR comment chain. In that PR I see Johannes asking for a
/submit, but no submit; next I would check if a patch with the same
title came through in the mailing list by searching on the
public-inbox.org mirror:
https://public-inbox.org/git/?q=is_directory+dir_exists
Looks like, no, a patch with those hotwords wasn't mailed. Finally, I
would check the project to see if it's still an issue:
$ cd my-git-dir/
$ git grep is_directory
I still see 30 instances of is_directory in the codebase, so looks like
we haven't made this change. :)
>
> In case this issue is not suitable for my first contribution, I have
> also found this:
> https://github.com/gitgitgadget/git/issues/379
This is also a fine change if you want to make it.
Good luck, and remember it's fine to ask the mentor for the project you
ultimately want to help on for help, code review in advance, etc.
- Emily
next prev parent reply other threads:[~2019-10-21 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 10:39 [Outreachy] First contribution Miriam R.
2019-10-21 18:35 ` Emily Shaffer [this message]
2019-10-22 13:42 ` Miriam R.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021183519.GA139951@google.com \
--to=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=mirucam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).