From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 554A71F463 for ; Wed, 11 Sep 2019 18:47:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730031AbfIKSrU (ORCPT ); Wed, 11 Sep 2019 14:47:20 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43209 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729016AbfIKSrU (ORCPT ); Wed, 11 Sep 2019 14:47:20 -0400 X-Originating-IP: 1.186.12.58 Received: from localhost (unknown [1.186.12.58]) (Authenticated sender: me@yadavpratyush.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 733571C0002; Wed, 11 Sep 2019 18:47:18 +0000 (UTC) Date: Thu, 12 Sep 2019 00:17:16 +0530 From: Pratyush Yadav To: Birger Skogeng Pedersen Cc: Bert Wesarg , Git List Subject: Re: feature request, git-gui: add hotkey to toggle amend/new Message-ID: <20190911184716.quzqnjf4o55taop6@yadavpratyush.com> References: <20190903124541.2p5hmknolh2dwqh5@yadavpratyush.com> <971bbc44-d3d4-552d-d18e-58a2315c6183@kdbg.org> <20190904174103.nrntgwv6zdqyjqsh@yadavpratyush.com> <8a726eea-f461-db90-7e36-70b708ff8915@kdbg.org> <20190910085446.GB32239@gmail.com> <20190911183419.jea27ctvcdl5olp3@yadavpratyush.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190911183419.jea27ctvcdl5olp3@yadavpratyush.com> User-Agent: NeoMutt/20180716 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 12/09/19 12:04AM, Pratyush Yadav wrote: > On 11/09/19 12:27PM, Birger Skogeng Pedersen wrote: > > Hi Pratyush, > > > > I'm hoping this will be merged, even without changing the radio > > selectors to a checkbox(?). The patch from Bert resolves the issue I > > raised about wanting the hotkey. > > What do you think? > > What do you mean by "this"? I am guessing you mean [0]. > > I'm afraid that patch conflicts with Bert's change [1] to using a > checkbox. Since both patches are in flight, it makes more sense to base > your work off his. If I merge your patch now, I'll have to revert it as > soon as it is time to merge Bert's, and then rework your patch. > > Also, after Bert's patch, the toggling becomes much simpler. All you'd > have to do is something like: > > bind . <$M1B-Key-e> { > # Toggle commit type. > set commit_type_is_amend [expr {!$commit_type_is_amend}] > do_select_commit_type > } I forgot to mention one more thing. You'd also want to mark the menu entry of the amend toggle with Ctrl+e keybinding, like we do for all other bindings (F5 for rescan, Ctrl+T for staging, etc.). -- Regards, Pratyush Yadav