git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Pratyush Yadav <me@yadavpratyush.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Birger Skogeng Pedersen <birger.sp@gmail.com>,
	Bert Wesarg <bert.wesarg@googlemail.com>,
	Git List <git@vger.kernel.org>,
	bouncingcats@gmail.com
Subject: Re: feature request, git-gui: add hotkey to toggle amend/new
Date: Wed, 4 Sep 2019 23:16:43 +0530	[thread overview]
Message-ID: <20190904174103.nrntgwv6zdqyjqsh@yadavpratyush.com> (raw)
In-Reply-To: <971bbc44-d3d4-552d-d18e-58a2315c6183@kdbg.org>

On 04/09/19 08:24AM, Johannes Sixt wrote:
> Am 03.09.19 um 14:45 schrieb Pratyush Yadav:
> > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it 
> > immediately takes me to the "Amend last commit" option. Then I can press 
> > space to select it and Tab again to get back to the commit message.
> 
> That works on Windows with Ctrl+Shift+Tab, too.
> 
> > Also, since we are on this topic, how about making the "Amend last 
> > commit" button a toggle instead? This would act as a "turn amend mode 
> > on/off" button. Since "Amend last commit" and "New Commit" are mutually 
> > exclusive, a single toggle to switch between those modes makes sense to 
> > me.
> 
> That is worth a try. The check box title offers a natural hotkey then:
> "_A_mend last commit", Alt-a.

Right now, the binding proposed is Ctrl-e.  My mental model for the key 
bindings as of now is having the "actions" bound to Ctrl, and bindings 
that move you around in the UI bound to Alt.  So it makes more sense to 
me to have a "amend toggle" bound to Ctrl.  Maybe that's just me though.  
Anyone else care to chime in?

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2019-09-04 17:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 10:51 feature request, git-gui: add hotkey to toggle amend/new Birger Skogeng Pedersen
2019-09-02 16:25 ` Birger Skogeng Pedersen
2019-09-02 18:07   ` Bert Wesarg
2019-09-02 19:49     ` Birger Skogeng Pedersen
2019-09-02 19:56       ` [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
2019-09-03  8:52         ` Bert Wesarg
2019-09-03 10:25           ` Bert Wesarg
2019-09-03 16:20           ` Bert Wesarg
2019-09-02 20:12       ` feature request, git-gui: add hotkey to toggle amend/new Bert Wesarg
2019-09-02 20:15         ` Bert Wesarg
2019-09-03  5:37           ` Birger Skogeng Pedersen
2019-09-03 12:45             ` Pratyush Yadav
2019-09-03 14:06               ` Birger Skogeng Pedersen
2019-09-03 17:34                 ` Pratyush Yadav
2019-09-03 15:35               ` David
2019-09-03 17:27                 ` Pratyush Yadav
2019-09-04  6:24               ` Johannes Sixt
2019-09-04 17:46                 ` Pratyush Yadav [this message]
2019-09-04 17:54                   ` Birger Skogeng Pedersen
2019-09-04 18:52                   ` Johannes Sixt
2019-09-04 19:03                     ` Bert Wesarg
2019-09-10  8:54                       ` David Aguilar
2019-09-11 10:27                         ` Birger Skogeng Pedersen
2019-09-11 18:34                           ` Pratyush Yadav
2019-09-11 18:47                             ` Pratyush Yadav
2019-09-03  1:01     ` David
2019-09-03  8:44       ` Bert Wesarg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190904174103.nrntgwv6zdqyjqsh@yadavpratyush.com \
    --to=me@yadavpratyush.com \
    --cc=bert.wesarg@googlemail.com \
    --cc=birger.sp@gmail.com \
    --cc=bouncingcats@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).