From: Pratyush Yadav <me@yadavpratyush.com>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: Birger Skogeng Pedersen <birger.sp@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears
Date: Tue, 3 Sep 2019 22:45:11 +0530 [thread overview]
Message-ID: <20190903171511.cd6vwn4kz7bdpose@yadavpratyush.com> (raw)
In-Reply-To: <CAKPyHN3=QY4+XNhQPq09_PALFwfR5bWBs7q6m6LkfFoW-xeCug@mail.gmail.com>
On 02/09/19 09:13PM, Bert Wesarg wrote:
> On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> >
[snip]
> > > On second thought, wouldn't it make more sense to expand the
> > > commit
> > > message buffer instead? The point of resizing that pane is to see more
> > > of the commit message. So it makes more sense to make the commit message
> > > buffer take up all the vertical space, rather than making the scrollbar
> > > move.
> >
> > it is, I just broke that ;-)
>
> is fixed in GitHub:
>
> wget https://github.com/bertwesarg/git-gui/commit/56163547604f44688e208393f8941efaf5247d40.patch
I tried the patch out. Works fine on Linux. Thanks.
There is a minor typo in your commit message.
> Sugestted-by: Birger Skogeng Pedersen <birger.sp@gmail.com>
s/Sugestted/Suggested/
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
One more observation:
If I write a particularly long line (and consequently the scrollbar
becomes active), and then hit Ctrl+A to select all text, and then
backspace to delete it all, the scrollbar does not get updated. It still
shows the old position where is is "scrolled" halfway through. As soon
as I type in any other character, it takes the correct state, and
becomes disabled.
The vertical scrollbar behaves correctly in this scenario, and does take
the correct state and position as soon as I delete all text, so I
suspect it should be a small fix. Maybe a missed option or something
like that?
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2019-09-03 17:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 9:11 git-gui: Long lines in commit message gets hidden, no scrollbar appears Birger Skogeng Pedersen
2019-09-02 12:05 ` Bert Wesarg
2019-09-02 17:04 ` Birger Skogeng Pedersen
2019-09-02 18:12 ` Pratyush Yadav
2019-09-02 18:22 ` Birger Skogeng Pedersen
2019-09-02 18:44 ` Pratyush Yadav
2019-09-02 18:58 ` Pratyush Yadav
2019-09-02 19:03 ` Bert Wesarg
2019-09-02 19:13 ` Bert Wesarg
2019-09-02 19:28 ` Birger Skogeng Pedersen
2019-09-03 17:15 ` Pratyush Yadav [this message]
2019-09-04 19:39 ` Bert Wesarg
2019-09-04 22:35 ` Pratyush Yadav
2019-09-04 5:42 ` Birger Skogeng Pedersen
2019-09-04 14:04 ` Pratyush Yadav
2019-09-02 17:35 ` Junio C Hamano
2019-09-02 17:58 ` Bert Wesarg
2019-09-02 18:51 ` Birger Skogeng Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903171511.cd6vwn4kz7bdpose@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=bert.wesarg@googlemail.com \
--cc=birger.sp@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).