From: Mike Hommey <mh@glandium.org>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: Re: [PATCH] notes: avoid leaking duplicate entries
Date: Mon, 26 Aug 2019 10:55:02 +0900 [thread overview]
Message-ID: <20190826015502.qbgn557xjylju4o6@glandium.org> (raw)
In-Reply-To: <20190825051818.9621-1-mh@glandium.org>
On Sun, Aug 25, 2019 at 02:18:18PM +0900, Mike Hommey wrote:
> When add_note is called multiple times with the same key/value pair, the
> leaf_node it creates is leaked by notes_tree_insert.
For completeness, since I realized it was missing:
Signed-off-by: Mike Hommey <mh@glandium.org>
Mike
prev parent reply other threads:[~2019-08-26 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 5:18 [PATCH] notes: avoid leaking duplicate entries Mike Hommey
2019-08-25 7:10 ` Jeff King
2019-08-25 7:19 ` [PATCH] notes: avoid potential use-after-free during insertion Jeff King
2019-08-26 1:55 ` Mike Hommey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826015502.qbgn557xjylju4o6@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).