From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org, rsbecker@nexbridge.com,
johannes.schindelin@gmx.de, larsxschneider@gmail.com,
Johannes Sixt <j6t@kdbg.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] t0021: make sure clean filter runs
Date: Fri, 23 Aug 2019 10:34:47 +0200 [thread overview]
Message-ID: <20190823083447.GH20404@szeder.dev> (raw)
In-Reply-To: <20190822192240.GA4077@cat>
On Thu, Aug 22, 2019 at 08:22:40PM +0100, Thomas Gummerer wrote:
> v2 adds the comment as suggested by Szeder.
> + # Make sure that the file appears dirty, so checkout below has to
> + # run the configured filter.
Yeah, but that comment only really applied when setting both
timestamps. With a simple 'touch' it's more like
# Make sure that the file appears dirty or is at least racily clean,
# so ...
So the next reader will know that right away, that the author didn't
overlook racyness issue.
> + touch test.r &&
> filter_git checkout --quiet --no-progress empty-branch &&
> cat >expected.log <<-EOF &&
> START
> --
> 2.23.0.rc2.194.ge5444969c9
>
prev parent reply other threads:[~2019-08-23 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 6:56 [PATCH] t0021: make sure clean filter runs Thomas Gummerer
2019-08-20 18:01 ` Junio C Hamano
2019-08-21 14:52 ` Thomas Gummerer
2019-08-21 15:40 ` Junio C Hamano
2019-08-20 19:11 ` Johannes Sixt
2019-08-21 14:56 ` Thomas Gummerer
2019-08-21 18:23 ` Johannes Sixt
2019-08-21 22:03 ` SZEDER Gábor
2019-08-22 17:49 ` Thomas Gummerer
2019-08-22 18:04 ` Junio C Hamano
2019-08-22 18:52 ` Johannes Sixt
2019-08-22 19:22 ` [PATCH v2] " Thomas Gummerer
2019-08-22 20:01 ` Junio C Hamano
2019-08-23 8:34 ` SZEDER Gábor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823083447.GH20404@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=larsxschneider@gmail.com \
--cc=rsbecker@nexbridge.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).