From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Eric Wong <e@80x24.org>, Janos Farkas <chexum@gmail.com>,
git@vger.kernel.org
Subject: Re: 2.22.0 repack -a duplicating pack contents
Date: Wed, 3 Jul 2019 13:40:04 -0400 [thread overview]
Message-ID: <20190703174004.GB29348@sigill.intra.peff.net> (raw)
In-Reply-To: <874l4f8h4c.fsf@evledraar.gmail.com>
On Mon, Jun 24, 2019 at 11:30:59AM +0200, Ævar Arnfjörð Bjarmason wrote:
> I can't think of some great solution for this case, some thoughts:
>
> a. Perhaps we should split the *.keep flag into two things or
> more.
>
> We're using it for all of "I want this *.pack forever"
> (e.g. debugging) and "I want only this *.pack to contain the data
> found in it" (I/O & CPU optimization, what Janos wants) and "I'm
> git.git code avoiding a race with myself" (what you describe in #3).
>
> So maybe for the last of those we could also use and understand
> *.tmp-keep, at which point we wouldn't have this race described in
> #3. The 1st of those is a *.noprune and the 2nd is *.highlander (but
> whether it's worth splitting all that out v.s. just having
> *.tmp-keep is another matter).
Yeah, this is exactly the crux of the problem. We have two very
different things that are not distinguished by the reader. I left some
thoughts elsewhere in the thread:
https://public-inbox.org/git/20190703173814.GA29348@sigill.intra.peff.net/
-Peff
next prev parent reply other threads:[~2019-07-03 17:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 12:15 2.22.0 repack -a duplicating pack contents Janos Farkas
2019-06-23 14:54 ` Ævar Arnfjörð Bjarmason
2019-06-23 15:38 ` Janos Farkas
2019-06-23 18:02 ` Jeff King
2019-06-23 18:08 ` Eric Wong
2019-06-23 22:42 ` Jeff King
2019-06-24 9:30 ` Ævar Arnfjörð Bjarmason
2019-07-03 17:40 ` Jeff King [this message]
2019-06-28 7:02 ` [PATCH] repack: disable bitmaps-by-default if .keep files exist Eric Wong
2019-06-28 7:21 ` Ævar Arnfjörð Bjarmason
2019-06-29 19:16 ` [PATCH 2/1] repack: warn if bitmaps are explicitly enabled with keep files Eric Wong
2019-07-01 18:15 ` Junio C Hamano
2019-07-03 17:38 ` Jeff King
2019-07-03 18:10 ` Junio C Hamano
2019-07-03 18:37 ` Junio C Hamano
2019-07-03 21:24 ` Jeff King
2019-07-03 21:23 ` Jeff King
2019-07-08 17:40 ` Junio C Hamano
2019-06-29 8:03 ` [PATCH] repack: disable bitmaps-by-default if .keep files exist SZEDER Gábor
2019-06-29 19:13 ` [PATCH v2] " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703174004.GB29348@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=chexum@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).