From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] check_everything_connected: assume alternate ref tips are valid
Date: Mon, 1 Jul 2019 09:17:13 -0400 [thread overview]
Message-ID: <20190701131713.GA25349@sigill.intra.peff.net> (raw)
In-Reply-To: <20190701125945.GB4704@sigill.intra.peff.net>
On Mon, Jul 01, 2019 at 08:59:45AM -0400, Jeff King wrote:
> Yes, this is weakening the ties of the feature to the transport code.
> Traditionally transport-oriented code was the only user, but it also
> used the upload-pack transport under the hood to access the alternate
> (that was changed a while ago to for-each-ref for speed).
>
> I don't think there's any functional difference in having it there, but
> it could be moved to live alongside foreach_alt_odb() in sha1-file.c.
Looks like this hasn't quite hit 'next' yet, so perhaps we can
reorganize it as a preparatory patch.
[1/2]: object-store.h: move for_each_alternate_ref() from transport.h
[2/2]: check_everything_connected: assume alternate ref tips are valid
Documentation/rev-list-options.txt | 8 +++
builtin/receive-pack.c | 1 -
connected.c | 1 +
object-store.h | 2 +
revision.c | 29 +++++++++
sha1-file.c | 97 ++++++++++++++++++++++++++++++
t/perf/p5600-clone-reference.sh | 27 +++++++++
t/t5618-alternate-refs.sh | 60 ++++++++++++++++++
transport.c | 97 ------------------------------
transport.h | 2 -
10 files changed, 224 insertions(+), 100 deletions(-)
create mode 100755 t/perf/p5600-clone-reference.sh
create mode 100755 t/t5618-alternate-refs.sh
-Peff
next prev parent reply other threads:[~2019-07-01 13:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 10:11 [PATCH] check_everything_connected: assume alternate ref tips are valid Jeff King
2019-06-28 10:18 ` Jeff King
2019-06-28 12:51 ` Derrick Stolee
2019-06-29 7:43 ` Jeff King
2019-07-01 12:25 ` Derrick Stolee
2019-07-01 12:59 ` Jeff King
2019-07-01 13:17 ` Jeff King [this message]
2019-07-01 13:17 ` [PATCH 1/2] object-store.h: move for_each_alternate_ref() from transport.h Jeff King
2019-07-01 13:23 ` Derrick Stolee
2019-07-01 13:18 ` [PATCH v2 2/2] check_everything_connected: assume alternate ref tips are valid Jeff King
2019-07-03 9:12 ` SZEDER Gábor
2019-07-03 16:41 ` Jeff King
2019-07-03 16:46 ` Junio C Hamano
2019-07-03 16:50 ` SZEDER Gábor
2019-07-03 17:05 ` Junio C Hamano
2019-07-01 17:02 ` [PATCH] " Taylor Blau
2019-07-02 5:29 ` Jeff King
2019-06-28 16:22 ` Junio C Hamano
2019-06-29 7:55 ` Jeff King
2019-07-01 12:26 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701131713.GA25349@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).