From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Derrick Stolee <stolee@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/6] test-lib: introduce test_commit_bulk
Date: Fri, 28 Jun 2019 20:25:42 -0400 [thread overview]
Message-ID: <20190629002542.GF2625@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cQAKVOqYH-CcqzViP_zuKwg5fWO2_i8=Z5t=BVf9uoAXQ@mail.gmail.com>
On Fri, Jun 28, 2019 at 05:32:35PM -0400, Eric Sunshine wrote:
> > +# The message, filename, and contents strings are evaluated by the shell inside
> > +# double-quotes, with $n set to the current commit number. So you can do:
> > +#
> > +# test_commit_bulk --filename=file --contents='modification $n'
>
> Considering that test_commit_bulk() is intended to be used within a
> test body, and considering that test bodies are almost always
> encapsulated in single quotes, recommending single quoting the value
> of --contents= seems contraindicated. Double quotes likely would be
> better.
I hoped people reading it would realize that they would need to suppress
interpolation of $ one way or another. But I guess many people who touch
the test suite aren't actually prolific shell writers.
Anyway, I'm going to look into changing this to a printf string, which
would make this easier.
> > + in_dir=${indir:+-C "$indir"}
>
> Doesn't this suffer the problem in which some older/broken
> shells[1][2][3][4] incorrectly expand this to:
That line is leftover dead code; see my response to Junio.
> Same comment applies to other instances of ${indir:+-C "$indir"} below.
Those ones are fine because of the double-quotes (and whitespace
splitting on the replacement value happens before interpolation). Try
this:
x=''
y='with spaces'
sh -c 'for i in "$@"; do echo arg: $i; done' -- \
${x:+-x "$x"} \
${y:+-y "$y"}
-Peff
next prev parent reply other threads:[~2019-06-29 0:25 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 17:05 Git Test Coverage Report (Thurs. June 27) Derrick Stolee
2019-06-27 17:35 ` Derrick Stolee
2019-06-28 6:41 ` Jeff King
2019-06-28 9:37 ` [PATCH 0/6] easy bulk commit creation in tests Jeff King
2019-06-28 9:39 ` [PATCH 1/6] test-lib: introduce test_commit_bulk Jeff King
2019-06-28 12:35 ` Derrick Stolee
2019-06-28 18:05 ` Junio C Hamano
2019-06-29 0:09 ` Jeff King
2019-06-28 17:53 ` Junio C Hamano
2019-06-29 0:14 ` Jeff King
2019-06-28 18:44 ` Ævar Arnfjörð Bjarmason
2019-06-29 0:19 ` Jeff King
2019-06-28 21:32 ` Eric Sunshine
2019-06-28 23:04 ` SZEDER Gábor
2019-06-28 23:46 ` Eric Sunshine
2019-06-29 0:26 ` Jeff King
2019-06-29 8:24 ` SZEDER Gábor
2019-07-01 17:42 ` Junio C Hamano
2019-06-29 0:25 ` Jeff King [this message]
2019-06-28 9:39 ` [PATCH 2/6] t5310: increase the number of bitmapped commits Jeff King
2019-06-28 9:41 ` [PATCH 3/6] t3311: use test_commit_bulk Jeff King
2019-06-28 9:41 ` [PATCH 4/6] t5702: " Jeff King
2019-06-28 9:42 ` [PATCH 5/6] t5703: " Jeff King
2019-06-28 9:42 ` [PATCH 6/6] t6200: " Jeff King
2019-06-28 12:53 ` [PATCH 0/6] easy bulk commit creation in tests Johannes Schindelin
2019-06-29 0:30 ` Jeff King
2019-06-29 16:38 ` Elijah Newren
2019-06-30 6:34 ` Jeff King
2019-06-28 18:49 ` Ævar Arnfjörð Bjarmason
2019-06-29 0:45 ` Jeff King
2019-06-29 4:53 ` [PATCH v2 1/6] test-lib: introduce test_commit_bulk Jeff King
2019-07-01 22:24 ` Junio C Hamano
2019-07-02 5:16 ` Jeff King
2019-07-01 22:28 ` Junio C Hamano
2019-07-02 5:22 ` Jeff King
2019-06-28 6:45 ` Git Test Coverage Report (Thurs. June 27) Jeff King
2019-06-28 12:23 ` Derrick Stolee
2019-06-28 23:59 ` Jeff King
2019-06-29 1:36 ` Derrick Stolee
2019-06-29 5:15 ` Jeff King
2019-06-28 9:47 ` Duy Nguyen
2019-06-28 12:39 ` Derrick Stolee
2019-06-28 13:39 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629002542.GF2625@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).