From: Jeff King <peff@peff.net>
To: Pedro Larroy <pedro.larroy.lists@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: git bisect should return 1 when the first bad commit is found
Date: Sun, 23 Jun 2019 18:49:35 -0400 [thread overview]
Message-ID: <20190623224935.GD1100@sigill.intra.peff.net> (raw)
In-Reply-To: <CAC_CU1hHK5n4GcETbWFLBeqT_Y9LV6N32Rv0F0+OCXH2G0qg8Q@mail.gmail.com>
On Sun, Jun 23, 2019 at 01:32:16PM -0700, Pedro Larroy wrote:
> Thanks for your answer.
>
> I was expecting the HEAD to point to the first bad commit.
>
> In mercurial, the exit status tells you information about the
> bisection process: https://www.mercurial-scm.org/repo/hg/help/bisect
>
> Sure one can parse stdout, it's just more tedious than just checking
> the return code and having the HEAD left to the original bad commit.
I think it might be nice for Git to write a well-known refname (like
BISECT_RESULT or similar) so that you can refer to that instead of
having to read stdout (whether by machine or by a user
cutting-and-pasting). And I cannot offhand think of a particular reason
why that could not just be HEAD (instead of something bisect-specific)
after the bisect finishes.
We do not promise any particular value in HEAD now. The only downside
would be the minor cost to checkout the working tree of the known-bad
commit if we are not already there.
-Peff
next prev parent reply other threads:[~2019-06-24 2:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 22:33 git bisect should return 1 when the first bad commit is found Pedro Larroy
2019-06-13 18:22 ` Junio C Hamano
2019-06-23 20:32 ` Pedro Larroy
2019-06-23 22:49 ` Jeff King [this message]
2019-06-24 7:16 ` Christian Couder
2019-06-25 4:58 ` Jeff King
2019-06-24 18:41 ` Junio C Hamano
2019-06-25 4:53 ` Jeff King
2019-06-25 5:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623224935.GD1100@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pedro.larroy.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).