From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 4349B1F462 for ; Wed, 19 Jun 2019 21:42:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730626AbfFSVmP (ORCPT ); Wed, 19 Jun 2019 17:42:15 -0400 Received: from cloud.peff.net ([104.130.231.41]:44824 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1725908AbfFSVmP (ORCPT ); Wed, 19 Jun 2019 17:42:15 -0400 Received: (qmail 12950 invoked by uid 109); 19 Jun 2019 21:39:00 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Wed, 19 Jun 2019 21:39:00 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 10148 invoked by uid 111); 19 Jun 2019 21:43:03 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Wed, 19 Jun 2019 17:43:03 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 19 Jun 2019 17:42:13 -0400 Date: Wed, 19 Jun 2019 17:42:13 -0400 From: Jeff King To: Christian Couder Cc: git@vger.kernel.org, Junio C Hamano , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Jonathan Tan , SZEDER =?utf-8?B?R8OhYm9y?= , Christian Couder Subject: Re: [PATCH v4 0/4] Test oidmap Message-ID: <20190619214212.GE6571@sigill.intra.peff.net> References: <20190615100702.20762-1-chriscool@tuxfamily.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190615100702.20762-1-chriscool@tuxfamily.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Jun 15, 2019 at 12:06:58PM +0200, Christian Couder wrote: > Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh > oidmap has no specific test. The goal of this small patch series is to > change that and also improve oidmap a bit while at it. > > Changes compared to V3 are the following: > > - removed "hash" command in test-oidmap.c and "hash" test in > t0016-oidmap.sh as suggested by Peff, > > - added patch 4/4 which does the same as above in test-hashmap.c and > t0011-hashmap.sh as suggested by Peff. This version looks good to me. I do think that sha1hash() will eventually go away in favor of oidhash(), but we can approach that separately, and convert oidmap along with everyone else. It looks like we are close to being able to do that now. Grepping for sha1hash shows just about everybody dereferencing an oid object, except for the call in pack-objects.c. And skimming the callers there, they all appear to have an oid object, too. -Peff