From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 3/4] rebase: fix garbled progress display with '-x'
Date: Mon, 17 Jun 2019 20:40:47 +0200 [thread overview]
Message-ID: <20190617184047.GK31952@szeder.dev> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1906141356140.44@tvgsbejvaqbjf.bet>
On Fri, Jun 14, 2019 at 08:42:29PM +0200, Johannes Schindelin wrote:
> > > > However, if the terminal were smart, then we would have to deal with
> > > > ANSI escape suddenly popping up...
> > >
> > > And I fear that is *exactly* what makes
> > > https://dev.azure.com/gitgitgadget/git/_build/results?buildId=10539&view=ms.vss-test-web.build-test-results-tab
> > > fail...
> >
> > Isn't it a sign of a problem in that Windows test environment that
> > it mistakenly believes that the terminal is smart, even though it has
> > been explicitly set to dumb?
>
> I investigated this today.
>
> Mind you, I still think that it is totally inappropriate for a test case
> with the title 'rebase -i respects rebase.missingCommitsCheck = warn' to
> validate the expected progress output, in particular since it verifies the
> progress on non-sophisticated terminals, i.e. the totally least
> interesting and least common scenario.
>
> In short: I stand by my suggestion to fix these tests (i.e. ignore the
> progress altogether) in a preparatory patch in your patch series.
I agree and will try to get around to it in the coming days.
> In case you are interested in the details, please read on, otherwise just
> mark this mail as read and move on.
>
> Still with me? Well, here you go, enjoy the ride.
Sure!
[...]
> I hope you, dear reader, can appreciate the number of circumstances that
> had to come together to trigger this bug.
Thank you, it was both educational and entertaining :)
next prev parent reply other threads:[~2019-06-17 18:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 14:25 [PATCH] rebase: fix garbled progress display with '-x' SZEDER Gábor
2019-04-30 22:25 ` Johannes Schindelin
2019-05-01 23:16 ` SZEDER Gábor
2019-05-03 8:41 ` Johannes Schindelin
2019-06-11 12:38 ` SZEDER Gábor
2019-06-11 13:03 ` [PATCH v2 0/4] rebase/progress: add and use term_clear_line() SZEDER Gábor
2019-06-11 13:03 ` [PATCH v2 1/4] t3404-rebase-interactive: use the 'q_to_cr' helper SZEDER Gábor
2019-06-11 13:03 ` [PATCH v2 2/4] pager: add a helper function to clear the last line in the terminal SZEDER Gábor
2019-06-11 13:03 ` [PATCH v2 3/4] rebase: fix garbled progress display with '-x' SZEDER Gábor
2019-06-11 20:36 ` Junio C Hamano
2019-06-11 21:11 ` SZEDER Gábor
2019-06-12 19:14 ` Johannes Schindelin
2019-06-12 19:41 ` SZEDER Gábor
2019-06-13 7:54 ` Johannes Schindelin
2019-06-14 18:42 ` Johannes Schindelin
2019-06-17 18:40 ` SZEDER Gábor [this message]
2019-06-17 19:13 ` SZEDER Gábor
2019-06-17 19:25 ` SZEDER Gábor
2019-06-24 18:39 ` SZEDER Gábor
2019-06-25 10:08 ` Phillip Wood
2019-06-25 11:31 ` SZEDER Gábor
2019-06-25 13:33 ` Phillip Wood
2019-06-25 18:00 ` Phillip Wood
2019-06-25 11:38 ` Johannes Schindelin
2019-06-25 13:35 ` Phillip Wood
2019-06-11 20:48 ` Junio C Hamano
2019-06-11 23:50 ` SZEDER Gábor
2019-06-12 16:21 ` Junio C Hamano
2019-06-11 13:03 ` [PATCH v2 4/4] progress: use term_clear_line() SZEDER Gábor
2019-06-12 20:00 ` Johannes Schindelin
2019-06-24 18:13 ` [PATCH v3 0/5] rebase/progress: add and " SZEDER Gábor
2019-06-24 18:13 ` [PATCH v3 1/5] t3404: modernize here doc style SZEDER Gábor
2019-06-25 9:06 ` Johannes Schindelin
2019-06-24 18:13 ` [PATCH v3 2/5] t3404: make the 'rebase.missingCommitsCheck=ignore' test more focused SZEDER Gábor
2019-06-25 9:07 ` Johannes Schindelin
2019-06-24 18:13 ` [PATCH v3 3/5] pager: add a helper function to clear the last line in the terminal SZEDER Gábor
2019-06-24 18:13 ` [PATCH v3 4/5] rebase: fix garbled progress display with '-x' SZEDER Gábor
2019-06-27 13:42 ` [PATCH v3.1 " SZEDER Gábor
2019-06-24 18:13 ` [PATCH v3 5/5] progress: use term_clear_line() SZEDER Gábor
2019-06-25 9:10 ` Johannes Schindelin
2019-06-25 19:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617184047.GK31952@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).