From: Jeff King <peff@peff.net>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: git@vger.kernel.org, jrn@google.com
Subject: Re: [PATCH v3] grep: provide sane default to grep_source struct
Date: Wed, 22 May 2019 00:01:00 -0400 [thread overview]
Message-ID: <20190522040100.GA31212@sigill.intra.peff.net> (raw)
In-Reply-To: <20190522003402.77767-1-emilyshaffer@google.com>
On Tue, May 21, 2019 at 05:34:02PM -0700, Emily Shaffer wrote:
> I think Peff and Jonathan are right. If someone does want to hack away
> on something in the very early stages, the BUG() line gives a pretty
> clear indicator of what to modify to make it work.
>
> I also moved the BUG() to grep_source_1() to keep it close to the error
> itself and reflowed the commit message.
Thanks. This version looks good to me (though if you took any of
Jonathan's suggestions in the other part of the thread that would be
fine with me, too).
-Peff
next prev parent reply other threads:[~2019-05-22 4:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 2:00 [RFC PATCH] grep: provide sane default to grep_source struct Emily Shaffer
2019-05-16 3:07 ` Junio C Hamano
2019-05-16 3:13 ` Jonathan Nieder
2019-05-16 3:11 ` Jonathan Nieder
2019-05-16 21:05 ` Emily Shaffer
2019-05-16 21:44 ` [PATCH v2] " Emily Shaffer
2019-05-16 22:02 ` Jeff King
2019-05-21 23:52 ` Emily Shaffer
2019-05-22 0:17 ` Jonathan Nieder
2019-05-22 0:34 ` [PATCH v3] " Emily Shaffer
2019-05-22 0:58 ` Jonathan Nieder
2019-05-22 4:01 ` Jeff King [this message]
2019-05-23 20:23 ` [PATCH v4] grep: fail if call could output and name is null Emily Shaffer
2019-05-23 20:34 ` Jonathan Nieder
2019-05-28 17:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522040100.GA31212@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=jrn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).