From: Mike Hommey <mh@glandium.org>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org, jnareb@gmail.com, jrnieder@google.com,
szeder.dev@gmail.com, Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 2/2] revision: keep topo-walk free of unintersting commits
Date: Wed, 22 May 2019 11:19:28 +0900 [thread overview]
Message-ID: <20190522021928.tsmg2rij6l44xvdj@glandium.org> (raw)
In-Reply-To: <20190521135953.214701-1-dstolee@microsoft.com>
On Tue, May 21, 2019 at 09:59:53AM -0400, Derrick Stolee wrote:
> When updating the topo-order walk in b454241 (revision.c: generation-based
> topo-order algorithm, 2018-11-01), the logic was a huge rewrite of the
> walk logic. In that massive change, we accidentally included the
> UNINTERESTING commits in expand_topo_walk(). This means that a simple
> query like
>
> git rev-list --topo-order HEAD~1..HEAD
>
> will expand the topo walk for all commits reachable from HEAD, and not
> just one commit.
>
> This change should speed up these cases, but there is still a need
> for corrected commit-date for some A..B queries.
>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> ---
>
> Sorry for the patch-spam, but I took a moment to check this command
> on the Git repo, and was able to reproduce the slowness. That didn't
> make sense to me, so I added some log messages to expand_topo_walk()
> and notices we were walking the UNINITERESTING commits. This is part
> of the reason the new logic is slower for A..B commands, but not the
> whole reason.
>
> You'll want this patch as well for a test.
Both patches help, thanks.
Mike
next prev parent reply other threads:[~2019-05-22 2:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 0:54 Revision walking, commit dates, slop Mike Hommey
2019-05-18 1:50 ` SZEDER Gábor
2019-05-18 3:58 ` Mike Hommey
2019-05-18 4:17 ` Mike Hommey
2019-05-18 12:01 ` SZEDER Gábor
2019-05-19 22:28 ` Jakub Narebski
2019-05-20 1:33 ` Derrick Stolee
2019-05-20 11:02 ` Jakub Narebski
2019-05-20 11:20 ` Derrick Stolee
2019-05-20 13:42 ` Jakub Narebski
2019-05-20 23:27 ` Jakub Narebski
2019-05-21 1:20 ` Derrick Stolee
2019-05-22 18:29 ` Jakub Narebski
2019-05-22 19:06 ` Derrick Stolee
2019-05-23 21:04 ` Jakub Narebski
2019-06-25 7:51 ` Jakub Narebski
2019-06-25 10:54 ` Derrick Stolee
2019-09-18 8:43 ` [RFC/PATCH] commit-graph: generation v5 (backward compatible date ceiling) Jakub Narebski
2019-09-18 12:26 ` Derrick Stolee
2019-05-21 13:14 ` [PATCH] revision: use generation for A..B --topo-order queries Derrick Stolee
2019-05-21 13:59 ` [PATCH 2/2] revision: keep topo-walk free of unintersting commits Derrick Stolee
2019-05-22 2:19 ` Mike Hommey [this message]
2019-05-21 2:00 ` Revision walking, commit dates, slop Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522021928.tsmg2rij6l44xvdj@glandium.org \
--to=mh@glandium.org \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=jrnieder@google.com \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).