From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Jeff King" <peff@peff.net>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Junio C Hamano" <gitster@pobox.com>,
"Johannes Sixt" <j6t@kdbg.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v2 1/7] run-command: add preliminary support for multiple hooks
Date: Wed, 15 May 2019 22:27:56 +0000 [thread overview]
Message-ID: <20190515222756.GJ7458@genre.crustytoothpaste.net> (raw)
In-Reply-To: <CACsJy8Ba98baQ2wZnMZyEva6gxO1ROZ4qJFTOdrCUXDMwrHnXA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2954 bytes --]
On Tue, May 14, 2019 at 07:46:17PM +0700, Duy Nguyen wrote:
> On Tue, May 14, 2019 at 7:24 AM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
> > - argv_array_push(&hook.args, p);
> > - while ((p = va_arg(args, const char *)))
> > - argv_array_push(&hook.args, p);
> > - hook.env = env;
> > + strbuf_reset(&path);
> > + strbuf_git_path(&path, "hooks/%s.d", name);
> > + d = opendir(path.buf);
> > + if (!d) {
> > + if (list)
> > + string_list_clear(list, 0);
> > + return 0;
> > + }
> > + while ((de = readdir(d))) {
> > + if (!strcmp(de->d_name, ".") || !strcmp(de->d_name, ".."))
> > + continue;
> > + strbuf_reset(&path);
> > + strbuf_git_path(&path, "hooks/%s.d/%s", name, de->d_name);
> > + if (has_hook(&path, 0, X_OK)) {
>
> Do we want to support hooks in subdirectories as well (if so, using
> dir-iterator.h might be more appropriate)
No, I don't think so. That's not what most other software does, and I
don't really think recursive behavior provides a lot of value.
> If not, what happens when "path" is a directory. X_OK could be set
> (and often are) on them too.
We get an exec failure when trying to run it, just like if you create a
directory in place of the existing hook now. I think that's a fine
behavior.
> > + if (list)
> > + string_list_append(list, path.buf);
> > + else
> > + return 1;
> > + }
> > + }
> > + closedir(d);
> > + strbuf_reset(&path);
> > + if (!list->nr) {
> > + return 0;
> > + }
> > +
> > + string_list_sort(list);
>
> This is going to be interesting on case-insensitive filesystems
> because we do strcmp by default, not the friendlier fspathcmp. And the
> ".exe" suffix might affect sort order too.
>
> But I suppose we just need to be clear here (in documentation). They
> can always prefix with a number to keep hook files in expected order.
Numbering is definitely the way I'd go on a case-insensitive file
system. Also, I don't think the ".exe" will be a problem in practice,
since generally you'd have to have a mix of binary and non-binary hooks,
which is unlikely to be super common.
> > diff --git a/run-command.h b/run-command.h
> > index a6950691c0..1b3677fcac 100644
> > --- a/run-command.h
> > +++ b/run-command.h
> > @@ -4,6 +4,7 @@
> > #include "thread-utils.h"
> >
> > #include "argv-array.h"
> > +#include "string-list.h"
>
> 'struct string_list;' should be enough (and a bit lighter) although I
> don't suppose it really matters.
I can make that change.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2019-05-15 22:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 0:23 [PATCH v2 0/7] Multiple hook support brian m. carlson
2019-05-14 0:23 ` [PATCH v2 1/7] run-command: add preliminary support for multiple hooks brian m. carlson
2019-05-14 12:46 ` Duy Nguyen
2019-05-15 22:27 ` brian m. carlson [this message]
2019-05-29 2:18 ` brian m. carlson
2019-05-14 15:12 ` Johannes Schindelin
2019-05-15 22:44 ` brian m. carlson
2019-05-16 19:11 ` Johannes Sixt
2019-05-17 20:31 ` Johannes Schindelin
2019-05-14 0:23 ` [PATCH v2 2/7] builtin/receive-pack: add " brian m. carlson
2019-05-14 0:23 ` [PATCH v2 3/7] rebase: " brian m. carlson
2019-05-14 12:56 ` Duy Nguyen
2019-05-14 17:58 ` Johannes Sixt
2019-05-15 22:55 ` brian m. carlson
2019-05-16 10:29 ` Duy Nguyen
2019-05-14 0:23 ` [PATCH v2 3/7] sequencer: " brian m. carlson
2019-05-14 0:23 ` [PATCH v2 4/7] builtin/worktree: add support for multiple post-checkout hooks brian m. carlson
2019-05-14 0:23 ` [PATCH v2 5/7] transport: add support for multiple pre-push hooks brian m. carlson
2019-05-14 0:23 ` [PATCH v2 6/7] config: allow configuration of multiple hook error behavior brian m. carlson
2019-05-14 13:20 ` Duy Nguyen
2019-05-15 23:10 ` brian m. carlson
2019-05-16 5:08 ` Jeff King
2019-05-16 5:02 ` Jeff King
2019-05-16 17:19 ` brian m. carlson
2019-05-16 21:52 ` Jeff King
2019-05-14 0:23 ` [PATCH v2 7/7] docs: document multiple hooks brian m. carlson
2019-05-14 13:38 ` Duy Nguyen
2019-05-14 0:51 ` [PATCH v2 0/7] Multiple hook support Jonathan Nieder
2019-05-14 1:59 ` brian m. carlson
2019-05-14 2:26 ` Jonathan Nieder
2019-05-16 0:42 ` brian m. carlson
2019-05-16 0:51 ` Jonathan Nieder
2019-05-16 4:51 ` Jeff King
2019-05-14 13:30 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515222756.GJ7458@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).