git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Dmitriy Smirnov" <dmitriy.smirnov@jetbrains.com>,
	"Torsten Bögershausen" <tboegi@web.de>,
	git@vger.kernel.org,
	"Kirill Likhodedov" <kirill.likhodedov@jetbrains.com>,
	"Aleksey Pivovarov" <aleksey.pivovarov@jetbrains.com>
Subject: Re: git add —ignore-errors causes --renormalize
Date: Tue, 29 Jan 2019 17:51:22 -0500	[thread overview]
Message-ID: <20190129225121.GD1895@sigill.intra.peff.net> (raw)
In-Reply-To: <20190129213533.GE13764@szeder.dev>

On Tue, Jan 29, 2019 at 10:35:33PM +0100, SZEDER Gábor wrote:

> t0025 with '--stress' usually fails within seconds when run on the
> merge of 'jk/add-ignore-errors-bit-assignment-fix' and 'master' [1]:

Thanks for the pointer. I mostly cargo-culted the test from the rest of
that script, so I didn't think too hard about race conditions. I think
the key difference is that the other tests are _actually_ using
--renormalize, which is going to re-hash the files and notice the line
ending change. And my test is not, so it will sometimes notice and
sometimes not.

It seems like we could probably solve it through some clever tweaking of
mtimes to make sure we have a consistent timestamp setup, but it's
resisting my quick efforts. I'm at an airport traveling right now, so I
may not get to it for a day or three.

-Peff

      reply	other threads:[~2019-01-29 22:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 15:22 git add —ignore-errors causes --renormalize Dmitriy Smirnov
2019-01-17 16:27 ` Jeff King
2019-01-17 16:45   ` Jeff King
2019-01-19 17:08   ` Torsten Bögershausen
2019-01-29 21:35   ` SZEDER Gábor
2019-01-29 22:51     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129225121.GD1895@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=aleksey.pivovarov@jetbrains.com \
    --cc=dmitriy.smirnov@jetbrains.com \
    --cc=git@vger.kernel.org \
    --cc=kirill.likhodedov@jetbrains.com \
    --cc=szeder.dev@gmail.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).