git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "Sérgio Peixoto" <sergio.peixoto@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Change on check-attr behavior
Date: Thu, 17 Jan 2019 11:07:52 -0500	[thread overview]
Message-ID: <20190117160752.GA29375@sigill.intra.peff.net> (raw)
In-Reply-To: <CAK3b1G+88a=xfO=6wfRi1SMy3xtca2NcFyxuBLKwSifb_L9xwA@mail.gmail.com>

On Thu, Jan 17, 2019 at 03:47:09PM +0000, Sérgio Peixoto wrote:

> I think there is a bug on the check-attr behavior of git when asking
> for the "allowed-ext" attribute.  Check the logs below to see that
> with version  2.20.1.windows.1 we get unspecified even the attribute
> is there as you can see when asking for all the attributes.
> 
> === OLD VERSION ===
> > git version
> git version 2.8.1.windows.1
> 
> > git check-attr -a test.py
> test.py: text: set
> test.py: allowed-ext: 100
> 
> > git check-attr allowed-ext test.py
> test.py: allowed-ext: 100
> 
> === NEW VERSION ===
> > git --version
> git version 2.20.1.windows.1
> 
> > git check-attr -a test.py
> test.py: text: set
> test.py: allowed-ext: 100
> 
> > git check-attr allowed-ext test.py
> test.py: allowed-ext: unspecified

I can't reproduce here (on Linux, but I don't think the attr code is
particularly Windows-specific).  Can you show us what's in your
.gitattributes file(s)?

-Peff

  reply	other threads:[~2019-01-17 16:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 15:47 Change on check-attr behavior Sérgio Peixoto
2019-01-17 16:07 ` Jeff King [this message]
2019-01-18  9:41   ` Sérgio Peixoto
2019-01-18 16:58     ` Jeff King
2019-01-18 21:34       ` [PATCH] attr: do not mark queried macros as unset Jeff King
2019-01-18 21:46         ` Jeff King
2019-01-18 22:19           ` Stefan Beller
2019-01-22  7:19             ` Jeff King
2019-01-22  9:50               ` Duy Nguyen
2019-01-22 22:00           ` Junio C Hamano
2019-01-21 10:05         ` Duy Nguyen
2019-01-22  7:21           ` Jeff King
2019-01-22  9:34         ` Duy Nguyen
2019-01-22 21:48         ` Junio C Hamano
2019-01-23  5:40           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117160752.GA29375@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=sergio.peixoto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).