git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Mazo, Andrey" <amazo@checkvideo.com>
To: "luke@diamand.org" <luke@diamand.org>
Cc: "Mazo, Andrey" <amazo@checkvideo.com>,
	"aoakley@roku.com" <aoakley@roku.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	"gitster@pobox.com" <gitster@pobox.com>,
	"merlorom@yahoo.fr" <merlorom@yahoo.fr>,
	"szeder.dev@gmail.com" <szeder.dev@gmail.com>,
	"vitor.hda@gmail.com" <vitor.hda@gmail.com>
Subject: Re: [PATCHv2 1/2] git-p4: add failing test for shelved CL update involving move
Date: Wed, 16 Jan 2019 23:40:23 +0000	[thread overview]
Message-ID: <20190116234001.15234-1-amazo@checkvideo.com> (raw)
In-Reply-To: <20190114235524.3947-2-luke@diamand.org>

> 
> Updating a shelved P4 changelist where one or more files have
> been moved does not work. Add a test for this.
> 
> The problem is that P4 requires a complete list of the files being
> changed, and move/rename only includes the _source_ in the case of
> updating a shelved changelist. This results in errors from Perforce
> such as:
> 
>   //depot/src - needs tofile //depot/dst
>   Submit aborted -- fix problems then use 'p4 submit -c 1234'
> 

Shouldn't a similar test case and a fix be added for the "copy" case too?
The code looks very similar to the "move" case, so will probably fail in a similar way, right?

For the "move" test case and the fix, please, feel free to add my
Acked-by: Andrey Mazo <amazo@checkvideo.com>
(if it's of any use)

Thank you,
Andrey

      parent reply	other threads:[~2019-01-16 23:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 23:55 [PATCHv2 0/2] git-p4: handle moved files when updating a P4 shelve Luke Diamand
2019-01-14 23:55 ` [PATCHv2 1/2] git-p4: add failing test for shelved CL update involving move Luke Diamand
2019-01-14 23:55   ` [PATCHv2 2/2] git-p4: handle update of moved files when updating a shelve Luke Diamand
2019-01-16 23:40   ` Mazo, Andrey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190116234001.15234-1-amazo@checkvideo.com \
    --to=amazo@checkvideo.com \
    --cc=aoakley@roku.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=luke@diamand.org \
    --cc=merlorom@yahoo.fr \
    --cc=szeder.dev@gmail.com \
    --cc=vitor.hda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).