From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] drop vcs-svn experiment
Date: Fri, 17 Aug 2018 22:26:05 -0700 [thread overview]
Message-ID: <20180818052605.GA241538@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180817190310.GA5360@sigill.intra.peff.net>
Hi,
Jeff King wrote:
> The code in vcs-svn was started in 2010 as an attempt to
> build a remote-helper for interacting with svn repositories
> (as opposed to git-svn). However, we never got as far as
> shipping a mature remote helper, and the last substantive
> commit was e99d012a6bc in 2012.
I do use svn-fe occasionally, and have done so in the past few years.
That said, it's probably not worth keeping this in tree just for me.
> We do have a git-remote-testsvn, and it is even installed as
> part of "make install".
At a minimum, we should stop doing that.
[...]
> We also ship contrib/svn-fe, which builds on the vcs-svn
> work. However, it does not seem to build out of the box for
> me, as the link step misses some required libraries for
> using libgit.a.
What libraries do you mean? It builds and runs fine for me with
$ git diff
diff --git i/contrib/svn-fe/Makefile w/contrib/svn-fe/Makefile
index e8651aaf4b5..bd709f8d83b 100644
--- i/contrib/svn-fe/Makefile
+++ w/contrib/svn-fe/Makefile
@@ -4,7 +4,7 @@ CC = cc
RM = rm -f
MV = mv
-CFLAGS = -g -O2 -Wall
+CFLAGS = -g -O2 -Wall -pthread
LDFLAGS =
EXTLIBS = -lz
which appears to be platform related, not due to some internal change
in Git.
[...]
> Of course, I could be completely wrong about people using this. Maybe
> svn-fe builds are just completely broken on my system, and maybe people
> really do use testsvn::. But if so, they certainly aren't talking about
> it on the mailing list. :)
My take:
- svn-fe works fine and has been useful to me, though its Makefile
could likely be simplified and made more user-friendly
- I've benefited from the test coverage of having this in-tree
- testsvn:: is a demo and at a minimum we ought not to install it
with "make install"
- keeping this in-tree for the benefit of just one user is excessive,
so removing it is probably the right thing
- it would be nice if the commit removing this code from Git includes
a note to help people find its new home
Would you mind holding off until I'm able to arrange that last bit?
Thanks,
Jonathan
next prev parent reply other threads:[~2018-08-18 5:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 19:03 [RFC/PATCH] drop vcs-svn experiment Jeff King
2018-08-17 19:33 ` Todd Zullinger
2018-08-18 5:26 ` Jonathan Nieder [this message]
2018-08-18 15:03 ` Jeff King
2018-10-04 4:10 ` Jeff King
2018-10-04 4:16 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180818052605.GA241538@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).