From: "Florian Gamböck" <mail@floga.de>
To: git@vger.kernel.org
Cc: "Szeder Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Stefan Beller" <sbeller@google.com>
Subject: [PATCH v2 0/1] completion: dynamic completion loading
Date: Tue, 10 Apr 2018 22:28:14 +0200 [thread overview]
Message-ID: <20180410202758.5877-1-mail@floga.de> (raw)
In this small patch I want to introduce a way to dynamically load completion
scripts for external subcommands.
A few years ago, you would put a completion script (which defines a Bash
function _git_foo for a custom git subcommand foo) into
/etc/bash_completion.d, or save it somewhere in your $HOME and source it
manually in your .bashrc.
Starting with bash-completion v2.0 (or, to be absolutely exact, the preview
versions started at v1.90), completion scripts are not sourced at bash startup
anymore. Rather, when typing in a command and trigger completion by pressing
the TAB key, the new bash-completion's main script looks for a script with the
same name as the typed command in the completion directory, sources it, and
provides the completions defined in this script.
However, that only works for top level commands. After a completion script has
been found, the logic is delegated to this script. This means, that the
completion of subcommands must be handled by the corresponding completion
script.
As it is now, git is perfectly able to call custom completion functions, iff
they are already defined when calling the git completion. With my patch, git
uses an already defined loader function of bash-completion (or continues
silently if this function is not found), loads an external completion script,
and provides its completions.
An example for an external completion script would be
/usr/share/bash-completion/completions/git-foo for a git subcommand foo.
Changes since v1 (RFC):
- Re-arranged if-fi statement to increase readability (suggested by Junio C
Hamano)
- Re-worded commit message to include the exakt version of bashcomp that
introduced dynamic loading (suggested by Stefan Beller)
Florian Gamböck (1):
completion: load completion file for external subcommand
contrib/completion/git-completion.bash | 10 ++++++++++
1 file changed, 10 insertions(+)
--
2.16.1
next reply other threads:[~2018-04-10 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 20:28 Florian Gamböck [this message]
2018-04-10 20:28 ` [PATCH v2 1/1] completion: load completion file for external subcommand Florian Gamböck
2018-04-18 19:51 ` SZEDER Gábor
2018-04-19 19:07 ` Florian Gamböck
2018-04-23 15:12 ` SZEDER Gábor
2018-04-23 17:32 ` Florian Gamböck
2018-04-25 14:40 ` SZEDER Gábor
2018-04-29 11:15 ` Florian Gamböck
2018-04-29 13:08 ` SZEDER Gábor
2018-04-29 14:09 ` Florian Gamböck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410202758.5877-1-mail@floga.de \
--to=mail@floga.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).