From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v2 2/2] perf: add test showing exponential growth in path globbing
Date: Wed, 10 May 2017 16:33:11 -0700 [thread overview]
Message-ID: <20170510233311.GE28740@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20170510225316.31680-3-avarab@gmail.com>
Hi,
Ævar Arnfjörð Bjarmason wrote:
> Add a test showing that ls-files times grow exponentially in the face
> of some pathological globs, whereas refglobs via for-each-ref don't in
> practice suffer from the same issue.
Cool.
[...]
> --- /dev/null
> +++ b/t/perf/p0100-globbing.sh
> @@ -0,0 +1,48 @@
> +#!/bin/sh
> +
> +test_description="Tests pathalogical globbing performance
> +
> +Shows how Git's globbing performance performs when given the sort of
> +pathalogical patterns described in at https://research.swtch.com/glob
s/pathalogical/pathological/
> +"
> +
> +. ./perf-lib.sh
> +
> +test_globs_big='10 25 50 75 100'
> +test_globs_small='1 2 3 4 5 6'
> +
> +test_perf_fresh_repo
> +
> +test_expect_success 'setup' '
> + for i in $(test_seq 1 100)
> + do
> + printf "a" >>refname &&
> + for j in $(test_seq 1 $i)
> + do
> + printf "a*" >>refglob.$i
> + done &&
> + echo b >>refglob.$i
> + done &&
> + test_commit $(cat refname) &&
> + for i in $(test_seq 1 100)
> + do
> + echo git tag $(cat refname)-$i
Leftover echo from debugging?
> + done &&
> + test_commit hello
> +'
> +
> +for i in $test_globs_big
> +do
> + test_perf "refglob((a*)^nb) against tag a^100; n = $i" '
> + git for-each-ref "refs/tags/$(cat refglob.'$i')b"
> + '
> +done
> +
> +for i in $test_globs_small
> +do
> + test_perf "fileglob((a*)^nb) against file (a^100).t; n = $i" '
> + git ls-files "$(cat refglob.'$i')b"
> + '
> +done
The rest looks sensible.
Thanks,
Jonathan
prev parent reply other threads:[~2017-05-10 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 22:53 [PATCH v2 0/2] perf: show that wildmatch() regressed for pathological cases in v2.0 Ævar Arnfjörð Bjarmason
2017-05-10 22:53 ` [PATCH v2 1/2] perf: add function to setup a fresh test repo Ævar Arnfjörð Bjarmason
2017-05-10 23:30 ` Jonathan Nieder
2017-05-11 0:00 ` Ævar Arnfjörð Bjarmason
2017-05-11 0:33 ` Junio C Hamano
2017-05-11 9:55 ` Junio C Hamano
2017-05-11 9:59 ` Ævar Arnfjörð Bjarmason
2017-05-10 22:53 ` [PATCH v2 2/2] perf: add test showing exponential growth in path globbing Ævar Arnfjörð Bjarmason
2017-05-10 23:33 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510233311.GE28740@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).