From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: "Marc Branchaud" <marcnarc@xiplink.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Michael Haggerty" <mhagger@alum.mit.edu>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v4 0/4] Make diff plumbing commands respect the indentHeuristic.
Date: Mon, 8 May 2017 23:27:29 -0400 [thread overview]
Message-ID: <20170509032729.bhq6ui23c3p6oyz3@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kbLKQ0jS0xfQO1MSp5T2_m9dShx0oYeTDAjDdUcydm3uQ@mail.gmail.com>
On Mon, May 08, 2017 at 10:13:41AM -0700, Stefan Beller wrote:
> > -test_expect_success 'diff: nice spaces with diff.indentHeuristic' '
> > +test_expect_success 'diff: nice spaces with diff.indentHeuristic=true' '
>
> Adding the '=true' seems weird to me (I'd think the true is implied,
> similar to C,
> where we do "if (!null_pointer)" instead of an explicit "!=null".
> However we do have these '=true' sprinkled all over the tests,
> so I guess it is a valid dialect in our test suite.
I think it's better to be explicit here. I think the original was less
about "implied true", as it was making the assumption that the feature
was off in the first place. Now that we've flipped that, just saying
"diff.indentHeuristic" is unclear whether you mean the "implied true"
of:
git -c diff.indentHeuristic diff ...
or if you mean setting diff.indentHeuristic at all but aren't saying
which (which I think is how the original meant it).
I dunno. I guess it is subjective, but IMHO the "=true" is much clearer.
-Peff
next prev parent reply other threads:[~2017-05-09 3:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 7:48 What's cooking in git.git (May 2017, #02; Mon, 8) Junio C Hamano
2017-05-08 14:54 ` Enabling the diff "indent" heuristic by default Marc Branchaud
2017-05-08 16:03 ` [PATCH v4 0/4] Make diff plumbing commands respect the indentHeuristic Marc Branchaud
2017-05-08 16:03 ` [PATCH v4 1/4] diff: make the indent heuristic part of diff's basic configuration Marc Branchaud
2017-05-08 16:03 ` [PATCH v4 2/4] diff: have the diff-* builtins configure diff before initializing revisions Marc Branchaud
2017-05-09 3:22 ` Jeff King
2017-05-11 19:22 ` Marc Branchaud
2017-05-08 16:03 ` [PATCH v4 3/4] diff: enable indent heuristic by default Marc Branchaud
2017-05-08 16:03 ` [PATCH v4 4/4] add--interactive: drop diff.indentHeuristic handling Marc Branchaud
2017-05-09 3:29 ` Jeff King
2017-05-08 17:13 ` [PATCH v4 0/4] Make diff plumbing commands respect the indentHeuristic Stefan Beller
2017-05-09 3:27 ` Jeff King [this message]
2017-05-09 3:32 ` Jeff King
2017-05-09 3:20 ` Enabling the diff "indent" heuristic by default Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509032729.bhq6ui23c3p6oyz3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marcnarc@xiplink.com \
--cc=mhagger@alum.mit.edu \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).