From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] completion: offer ctags symbol names for 'git log -S', '-G' and '-L:'
Date: Thu, 23 Mar 2017 20:52:56 -0400 [thread overview]
Message-ID: <20170324005256.ji2wijhyqnwbpp5t@sigill.intra.peff.net> (raw)
In-Reply-To: <20170323153839.24283-4-szeder.dev@gmail.com>
On Thu, Mar 23, 2017 at 04:38:39PM +0100, SZEDER Gábor wrote:
> Just like in the case of search patterns for 'git grep', see 29eec71f2
> (completion: match ctags symbol names in grep patterns, 2011-10-21)),
> a common thing to look for using 'git log -S', '-G' and '-L:' is the
> name of a symbol.
>
> Teach the completion for 'git log' to offer ctags symbol names after
> these options, both in stuck and in unstuck forms.
I think this makes sense and is an improvement over the status quo.
There are two gotchas with completing "-L" like this:
1. You still have to come up with the filename yourself for "-L".
2. The function name is actually a regex, so you can get bit when your
function name is a subset of another.
I have a script (below) which makes this easier (and I complete its
argument using the tags file). It's probably too gross to even go into
contrib, but I thought I'd share.
"log -S" sometimes benefits from limiting by filename, too, but it
depends what you're doing. I don't have a gross script for that. :)
-- >8 --
#!/usr/bin/env perl
if (!@ARGV) {
print STDERR "usage: git flog [options] <function>\n";
exit 1;
}
my $func = pop @ARGV;
my $file = get_file_from_tags($func);
my $regex = '[^A-Za-z_]' . $func . '[^A-Za-z0-9_]';
exec qw(git log), "-L:$regex:$file", @ARGV;
exit 1;
sub get_file_from_tags {
my $token = shift;
open(my $fh, '<', 'tags')
or die "unable to open tags: $!\n";
while (<$fh>) {
chomp;
# this isn't exactly right, as the Ex command may contain
# embedded tabs, but it's accurate for the token and filename,
# which come before, and probably good enough to match extension fields
# which come after
my @fields = split /\t/;
next unless $fields[0] eq $token;
# only look for functions; assumes your ctags uses the "kind"
# extension field. Note also that some implementations write the "kind:"
# header and some do not. This handles both.
next unless grep { /^(kind:\s*)?f$/ } @fields;
# there may be more, but we don't have any way of disambiguating,
# so just return the first match
return $fields[1];
}
die "unknown token: $token\n";
}
__END__
next prev parent reply other threads:[~2017-03-24 0:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 15:38 [PATCH 0/3] completion: updates to ctags symbol names SZEDER Gábor
2017-03-23 15:38 ` [PATCH 1/3] completion: put matching ctags symbol names directly into COMPREPLY SZEDER Gábor
2017-03-24 0:37 ` Jeff King
2017-03-23 15:38 ` [PATCH 2/3] completion: extract completing ctags symbol names into helper function SZEDER Gábor
2017-03-24 0:40 ` Jeff King
2017-03-23 15:38 ` [PATCH 3/3] completion: offer ctags symbol names for 'git log -S', '-G' and '-L:' SZEDER Gábor
2017-03-24 0:52 ` Jeff King [this message]
2017-03-30 10:06 ` SZEDER Gábor
2017-04-01 8:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324005256.ji2wijhyqnwbpp5t@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).