From: Eric Wong <e@80x24.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, Jann Horn <jannh@google.com>,
Brandon Williams <bmwill@google.com>,
git@vger.kernel.org, sbeller@google.com, bburky@bburky.com,
jrnieder@gmail.com
Subject: Re: [PATCH] http: inform about alternates-as-redirects behavior
Date: Sat, 4 Mar 2017 06:55:48 +0000 [thread overview]
Message-ID: <20170304065548.GA20734@whir> (raw)
In-Reply-To: <20170304031314.32bta4prahf7pfp7@sigill.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> The warning itself:
>
> > + warning("alternate disabled by http.followRedirects!=true: %s",
>
> feels like it could use some whitespace around the "!=", but maybe
> that's just me.
Yeah, I kinda wanted to emulate the command-line syntax.
Maybe rewording it a bit and showing how to enable it will
make more sense:
warning("alternate: %s", url);
warning(" may be enabled by -c http.followRedirects=true");
As well as keeping individual lines shorter and hopefully
easier-to-read.
next prev parent reply other threads:[~2017-03-04 7:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 1:35 [PATCH] http: inform about alternates-as-redirects behavior Eric Wong
2017-03-04 3:13 ` Jeff King
2017-03-04 3:49 ` Jeff King
2017-03-04 6:55 ` Eric Wong [this message]
2017-03-04 7:41 ` Jeff King
2017-03-04 8:36 ` [PATCH v2] " Eric Wong
2017-03-04 8:45 ` Jeff King
2017-03-06 18:03 ` Brandon Williams
2017-03-04 15:06 ` [PATCH] " Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170304065548.GA20734@whir \
--to=e@80x24.org \
--cc=bburky@bburky.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jannh@google.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).