* [PATCH] p5302: create repositories for index-pack results explicitly
@ 2017-02-05 11:43 René Scharfe
2017-02-06 14:41 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: René Scharfe @ 2017-02-05 11:43 UTC (permalink / raw)
To: Jeff King; +Cc: Junio C Hamano, Git List
Before 7176a314 (index-pack: complain when --stdin is used outside of a
repo) index-pack silently created a non-existing target directory; now
the command refuses to work unless it's used against a valid repository.
That causes p5302 to fail, which relies on the former behavior. Fix it
by setting up the destinations for its performance tests using git init.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
t/perf/p5302-pack-index.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/t/perf/p5302-pack-index.sh b/t/perf/p5302-pack-index.sh
index 5ee9211f98..99bdb16c85 100755
--- a/t/perf/p5302-pack-index.sh
+++ b/t/perf/p5302-pack-index.sh
@@ -13,6 +13,13 @@ test_expect_success 'repack' '
export PACK
'
+test_expect_success 'create target repositories' '
+ for repo in t1 t2 t3 t4 t5 t6
+ do
+ git init --bare $repo
+ done
+'
+
test_perf 'index-pack 0 threads' '
GIT_DIR=t1 git index-pack --threads=1 --stdin < $PACK
'
--
2.11.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] p5302: create repositories for index-pack results explicitly
2017-02-05 11:43 [PATCH] p5302: create repositories for index-pack results explicitly René Scharfe
@ 2017-02-06 14:41 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2017-02-06 14:41 UTC (permalink / raw)
To: René Scharfe; +Cc: Junio C Hamano, Git List
On Sun, Feb 05, 2017 at 12:43:29PM +0100, René Scharfe wrote:
> Before 7176a314 (index-pack: complain when --stdin is used outside of a
> repo) index-pack silently created a non-existing target directory; now
> the command refuses to work unless it's used against a valid repository.
> That causes p5302 to fail, which relies on the former behavior. Fix it
> by setting up the destinations for its performance tests using git init.
Ah, right. Thanks for catching this.
I think p5302 was wrong to rely on the old behavior, and your patch is
the right fix.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-06 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-05 11:43 [PATCH] p5302: create repositories for index-pack results explicitly René Scharfe
2017-02-06 14:41 ` Jeff King
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).