From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id AAF901F70F for ; Thu, 26 Jan 2017 14:39:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbdAZOjJ (ORCPT ); Thu, 26 Jan 2017 09:39:09 -0500 Received: from cloud.peff.net ([104.130.231.41]:45335 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803AbdAZOjJ (ORCPT ); Thu, 26 Jan 2017 09:39:09 -0500 Received: (qmail 5225 invoked by uid 109); 26 Jan 2017 14:39:08 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Thu, 26 Jan 2017 14:39:08 +0000 Received: (qmail 23450 invoked by uid 111); 26 Jan 2017 14:39:08 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Thu, 26 Jan 2017 09:39:08 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 26 Jan 2017 09:39:06 -0500 Date: Thu, 26 Jan 2017 09:39:06 -0500 From: Jeff King To: Johannes Schindelin Cc: Junio C Hamano , David Aguilar , Ramsay Jones , GIT Mailing-list Subject: Re: Fixing the warning about warning(""); was: Re: [PATCH] difftool.c: mark a file-local symbol with static Message-ID: <20170126143906.j6j64v4cyatwvlik@sigill.intra.peff.net> References: <20161201040234.3rnuttitneweedn5@sigill.intra.peff.net> <20161201185056.eso5rhec7izlbywa@sigill.intra.peff.net> <20170122052608.tpr5pihfgafhoynj@gmail.com> <20170124142346.u3d7l6772mtkgpcf@sigill.intra.peff.net> <20170124230500.h3fasbvutjkkke5h@sigill.intra.peff.net> <20170125183542.pe5qolexqqx6jhsi@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jan 26, 2017 at 12:16:10PM +0100, Johannes Schindelin wrote: > We could switch the DEVELOPER option on by default, when gcc or clang is > used at least. Otherwise the DEVELOPER option (which I like very much) > would not be able to live up to its full potential. I'm not sure that is a good idea. The options include -Werror, which is a good thing for developers to respect. But people using older versions of compilers, or on systems with slightly different header files, may see extraneous warnings. It's good to fix those warnings, but it is a big inconvenience to regular users who just want to build and use git. You could split the DEVELOPER options into two groups, though, and only enable when (after verifying that it is indeed gcc/clang in use). But now who is coming up with complicated fixes for the warning("") issue? :) -Peff