From: Max Kirillov <max@max630.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Max Kirillov <max@max630.net>,
Pat Thoyts <patthoyts@users.sourceforge.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [BUG/RFC] Git Gui: GIT_DIR leaks to spawned Git Bash
Date: Tue, 17 Jan 2017 20:42:24 +0200 [thread overview]
Message-ID: <20170117184224.GA23841@jessie.local> (raw)
In-Reply-To: <alpine.DEB.2.20.1701171145050.3469@virtualbox>
On Tue, Jan 17, 2017 at 11:52:29AM +0100, Johannes Schindelin wrote:
> Hi Max,
>
> On Tue, 17 Jan 2017, Max Kirillov wrote:
>
>> Apparently various GIT_* environment variables (most
>> interesting is GIT_DIR but AFAIR there were more) leak to
>> shell session launched from Git Gui's "Git Bash" menu item.
...
> After all, you won't even notice unless you use the very
> same Git Bash to navigate to a *different* worktree.
That's right, I haven't been noticing it myself for quite a
time. But once I decided to tweak my habits to having only
one terminal window opened, and immediately noticed.
> And having said *that*, I have to admit that I was unable to reproduce
I have found exact way to reproduce it and actually the
reason. Turns out to be obvious mistake in code. PR is in
github: https://github.com/git-for-windows/git/pull/1032
--
Max
next prev parent reply other threads:[~2017-01-17 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 22:40 [BUG/RFC] Git Gui: GIT_DIR leaks to spawned Git Bash Max Kirillov
2017-01-17 10:52 ` Johannes Schindelin
2017-01-17 18:42 ` Max Kirillov [this message]
2017-01-18 13:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117184224.GA23841@jessie.local \
--to=max@max630.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).