From: Eric Wong <e@80x24.org>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com, jnareb@gmail.com
Subject: Re: [PATCH v1] convert: add "status=delayed" to filter process protocol
Date: Sun, 8 Jan 2017 20:45:17 +0000 [thread overview]
Message-ID: <20170108204517.GA13779@starla> (raw)
In-Reply-To: <20170108191736.47359-1-larsxschneider@gmail.com>
larsxschneider@gmail.com wrote:
> +++ b/t/t0021/rot13-filter.pl
> +$DELAY{'test-delay1.r'} = 1;
> +$DELAY{'test-delay3.r'} = 3;
>
> open my $debug, ">>", "rot13-filter.log" or die "cannot open log file: $!";
>
> @@ -166,6 +176,15 @@ while (1) {
> packet_txt_write("status=abort");
> packet_flush();
> }
> + elsif ( $command eq "smudge" and
> + exists $DELAY{$pathname} and
> + $DELAY{$pathname} gt 0 ) {
Use '>' for numeric comparisons. 'gt' is for strings (man perlop)
Sidenote, staying <= 80 columns for the rest of the changes is
strongly preferred, some of us need giant fonts. I think what
Torsten said about introducing a new *_internal function can
also help with that.
Thanks.
next prev parent reply other threads:[~2017-01-08 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 19:17 [PATCH v1] convert: add "status=delayed" to filter process protocol larsxschneider
2017-01-08 20:14 ` Torsten Bögershausen
2017-01-11 9:48 ` Lars Schneider
2017-01-08 20:45 ` Eric Wong [this message]
2017-01-11 9:51 ` Lars Schneider
2017-01-08 23:42 ` Junio C Hamano
2017-01-10 22:11 ` Jakub Narębski
2017-01-10 23:33 ` Taylor Blau
2017-01-11 10:20 ` Lars Schneider
2017-01-11 14:53 ` Jakub Narębski
2017-01-11 20:41 ` Junio C Hamano
2017-01-11 9:43 ` Lars Schneider
2017-01-11 20:45 ` Junio C Hamano
[not found] ` <20170109233816.GA70151@Ida>
2017-01-11 10:13 ` Lars Schneider
2017-01-11 17:59 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108204517.GA13779@starla \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).