From: Jeff King <peff@peff.net>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] giteveryday: unbreak rendering with AsciiDoctor
Date: Wed, 4 Jan 2017 03:15:44 -0500 [thread overview]
Message-ID: <20170104081544.5htofa3zpgkvty7x@sigill.intra.peff.net> (raw)
In-Reply-To: <c3b21bbec96408c4d6698129fd336c24c9e2f0f0.1483373021.git.johannes.schindelin@gmx.de>
On Mon, Jan 02, 2017 at 05:04:05PM +0100, Johannes Schindelin wrote:
> The "giteveryday" document has a callout list that contains a code
> block. This is not a problem for AsciiDoc, but AsciiDoctor sadly was
> explicitly designed *not* to render this correctly [*1*]. The symptom is
> an unhelpful
>
> line 322: callout list item index: expected 1 got 12
> line 325: no callouts refer to list item 1
> line 325: callout list item index: expected 2 got 13
> line 327: no callouts refer to list item 2
>
> In Git for Windows, we rely on the speed improvement of AsciiDoctor (on
> this developer's machine, `make -j15 html` takes roughly 30 seconds with
> AsciiDoctor, 70 seconds with AsciiDoc), therefore we need a way to
> render this correctly.
>
> The easiest way out is to simplify the callout list, as suggested by
> AsciiDoctor's author, even while one may very well disagree with him
> that a code block hath no place in a callout list.
This looks like a good re-write to avoid the issue while maintaining the
meaning and flow of the original.
-Peff
next prev parent reply other threads:[~2017-01-04 8:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 16:03 [PATCH 0/2] Fix the documentation to build with asciidoctor Johannes Schindelin
2017-01-02 16:03 ` [PATCH 1/2] asciidoctor: fix user-manual to be built by `asciidoctor` Johannes Schindelin
2017-01-04 8:08 ` Jeff King
2017-01-05 10:05 ` Lars Schneider
2017-01-05 13:49 ` Johannes Schindelin
2017-01-05 16:45 ` Jeff King
2017-01-07 22:00 ` Junio C Hamano
2017-01-07 22:08 ` brian m. carlson
2017-01-10 22:59 ` Junio C Hamano
2017-01-07 22:03 ` Junio C Hamano
2017-01-08 3:27 ` Jeff King
2017-01-10 23:04 ` Junio C Hamano
2017-01-12 11:15 ` Johannes Schindelin
2017-01-12 19:30 ` Junio C Hamano
2017-01-13 18:31 ` Junio C Hamano
2017-01-02 16:04 ` [PATCH 2/2] giteveryday: unbreak rendering with AsciiDoctor Johannes Schindelin
2017-01-04 8:15 ` Jeff King [this message]
2017-01-07 22:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104081544.5htofa3zpgkvty7x@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).