From: Brandon Williams <bmwill@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
git@vger.kernel.org, jacob.keller@gmail.com
Subject: Re: [PATCHv3 3/3] submodule-config: clarify parsing of null_sha1 element
Date: Tue, 22 Nov 2016 10:36:39 -0800 [thread overview]
Message-ID: <20161122183639.GA65825@google.com> (raw)
In-Reply-To: <xmqqziksfae3.fsf@gitster.mtv.corp.google.com>
On 11/21, Junio C Hamano wrote:
> Stefan Beller <sbeller@google.com> writes:
>
> > +Whenever a submodule configuration is parsed in `parse_submodule_config_option`
> > +via e.g. `gitmodules_config()`, it will be overwrite the null_sha1 entry.
>
> It will overwrite? It will be overwritten? I guess it is the latter?
>
> > +So in the normal case, when HEAD:.gitmodules is parsed first and then overlayed
> > +with the repository configuration, the null_sha1 entry contains the local
> > +configuration of a submodule (e.g. consolidated values from local git
> > configuration and the .gitmodules file in the worktree).
> >
> > For an example usage see test-submodule-config.c.
I brought this up in v2, he must have just missed it for v3.
--
Brandon Williams
prev parent reply other threads:[~2016-11-22 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 1:35 [PATCHv3 0/3] submodule-config: clarify/cleanup docs and header Stefan Beller
2016-11-22 1:35 ` [PATCHv3 1/3] submodule config: inline config_from_{name, path} Stefan Beller
2016-11-22 1:35 ` [PATCHv3 2/3] submodule-config: rename commit_sha1 to commit_or_tree Stefan Beller
2016-11-22 1:35 ` [PATCHv3 3/3] submodule-config: clarify parsing of null_sha1 element Stefan Beller
2016-11-22 3:42 ` Junio C Hamano
2016-11-22 18:36 ` Brandon Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122183639.GA65825@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).