From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brandon Williams <bmwill@google.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
Stefan Beller <sbeller@google.com>,
Jens.Lehmann@web.de, Fredrik Gustafsson <iveqy@iveqy.com>,
Leandro Lucarella <leandro.lucarella@sociomantic.com>
Subject: Re: [PATCH v4 4/4] submodule_needs_pushing() NEEDSWORK when we can not answer this question
Date: Wed, 16 Nov 2016 22:31:00 +0100 [thread overview]
Message-ID: <20161116213100.GA38510@book.hvoigt.net> (raw)
In-Reply-To: <xmqqoa1fp72o.fsf@gitster.mtv.corp.google.com>
On Wed, Nov 16, 2016 at 11:18:07AM -0800, Junio C Hamano wrote:
> Heiko Voigt <hvoigt@hvoigt.net> writes:
>
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> > ---
>
> Needs retitle ;-) Here is what I tentatively queued.
Thanks ;-) Missed that one.
> submodule_needs_pushing(): explain the behaviour when we cannot answer
>
> When we do not have commits that are involved in the update of the
> superproject in our copy of submodule, we cannot tell if the remote
> end needs to acquire these commits to be able to check out the
> superproject tree. Explain why we answer "no there is no need/point
> in pushing from our submodule repository" in this case.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Sound fine to me.
Cheers Heiko
next prev parent reply other threads:[~2016-11-16 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 15:11 [PATCH v4 0/4] Speedup finding of unpushed submodules Heiko Voigt
2016-11-16 15:11 ` [PATCH v4 1/4] serialize collection of changed submodules Heiko Voigt
2016-11-16 15:11 ` [PATCH v4 2/4] serialize collection of refs that contain submodule changes Heiko Voigt
2016-11-16 15:11 ` [PATCH v4 3/4] batch check whether submodule needs pushing into one call Heiko Voigt
2016-11-16 15:11 ` [PATCH v4 4/4] submodule_needs_pushing() NEEDSWORK when we can not answer this question Heiko Voigt
2016-11-16 19:18 ` Junio C Hamano
2016-11-16 21:31 ` Heiko Voigt [this message]
2016-11-17 17:41 ` [PATCH v4 0/4] Speedup finding of unpushed submodules Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116213100.GA38510@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=Jens.Lehmann@web.de \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
--cc=leandro.lucarella@sociomantic.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).