From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,LOTS_OF_MONEY,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0BF421F4F8 for ; Thu, 20 Oct 2016 21:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757070AbcJTV5q (ORCPT ); Thu, 20 Oct 2016 17:57:46 -0400 Received: from cloud.peff.net ([104.130.231.41]:60320 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757053AbcJTV5p (ORCPT ); Thu, 20 Oct 2016 17:57:45 -0400 Received: (qmail 5227 invoked by uid 109); 20 Oct 2016 21:57:45 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Thu, 20 Oct 2016 21:57:45 +0000 Received: (qmail 30569 invoked by uid 111); 20 Oct 2016 21:58:07 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Thu, 20 Oct 2016 17:58:07 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 20 Oct 2016 17:57:42 -0400 Date: Thu, 20 Oct 2016 17:57:42 -0400 From: Jeff King To: Stefan Beller Cc: Johannes Schindelin , Junio C Hamano , "git@vger.kernel.org" Subject: Re: Drastic jump in the time required for the test suite Message-ID: <20161020215742.b5gzqvd2g6afjgmh@sigill.intra.peff.net> References: <20161019205638.m3ytxozzmeh47ml2@sigill.intra.peff.net> <20161020213803.7d7bymby7pouzij3@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Oct 20, 2016 at 02:53:36PM -0700, Stefan Beller wrote: > >> That said I really like the idea of having a helper that would eliminate the cat > >> for you, e.g. : > >> > >> git_test_helper_equal_stdin_or_diff_and_die -C super_repo status > >> --porcelain=v2 --branch --untracked-files=all <<-EOF > >> 1 A. N... 000000 100644 100644 $_z40 $HMOD .gitmodules > >> 1 AM S.M. 000000 160000 160000 $_z40 $HSUP sub1 > >> EOF > > > > I think that helper still ends up using "cat" and "diff" under the hood, > > I assumed that helper being a C program, that only needs to fork once > for the actual git call and then it sits idle to compare the exact output > from stdout to its stdin. Ah, I see. I thought you meant a shell helper. A C helper does drop 2 forks down to 1, but it would be nice if we could drop it to 0. -Peff