From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jan Keromnes <janx@linux.com>, git@vger.kernel.org
Subject: Re: [regression] `make profile-install` fails in 2.10.1
Date: Wed, 19 Oct 2016 18:37:06 -0400 [thread overview]
Message-ID: <20161019223706.re6a5m7n43vjfyzh@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqh988j7oo.fsf@gitster.mtv.corp.google.com>
On Wed, Oct 19, 2016 at 03:27:35PM -0700, Junio C Hamano wrote:
> Ouch. Thanks for a reminder. How about doing this for now?
> [...]
> test_expect_success 'git add --chmod=[+-]x changes index with already added file' '
> + rm -f foo3 xfoo3 &&
> echo foo >foo3 &&
Yeah, this makes sense. It does make me feel like the test should simply
be using xfoo27, or some name that is not otherwise used in the rest of
the script, but I don't mind doing the minimal thing.
-Peff
prev parent reply other threads:[~2016-10-19 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 11:15 [regression] `make profile-install` fails in 2.10.1 Jan Keromnes
2016-10-19 21:05 ` Jeff King
2016-10-19 22:27 ` Junio C Hamano
2016-10-19 22:30 ` Junio C Hamano
2016-10-19 22:38 ` Jeff King
2016-10-20 16:23 ` Junio C Hamano
2016-10-19 22:37 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019223706.re6a5m7n43vjfyzh@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=janx@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).