From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0E026207EC for ; Thu, 6 Oct 2016 19:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934875AbcJFTZS (ORCPT ); Thu, 6 Oct 2016 15:25:18 -0400 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:55618 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934857AbcJFTZQ (ORCPT ); Thu, 6 Oct 2016 15:25:16 -0400 Received: from dalias by brightrain.aerifal.cx with local (Exim 3.15 #2) id 1bsEHs-0004gm-00; Thu, 06 Oct 2016 19:25:00 +0000 Date: Thu, 6 Oct 2016 15:25:00 -0400 From: Rich Felker To: Jeff King Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Johannes Schindelin , Git , musl@lists.openwall.com Subject: Re: Regression: git no longer works with musl libc's regex impl Message-ID: <20161006192500.GS19318@brightrain.aerifal.cx> References: <20161004150848.GA7949@brightrain.aerifal.cx> <20161004152722.ex2nox43oj5ak4yi@sigill.intra.peff.net> <20161004154045.GT19318@brightrain.aerifal.cx> <20161006192339.3yddgxxk7jn7zfqx@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161006192339.3yddgxxk7jn7zfqx@sigill.intra.peff.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Oct 06, 2016 at 03:23:40PM -0400, Jeff King wrote: > On Thu, Oct 06, 2016 at 09:18:29PM +0200, Ævar Arnfjörð Bjarmason wrote: > > > On Tue, Oct 4, 2016 at 6:08 PM, Johannes Schindelin > > wrote: > > > As to making NO_REGEX conditional on REG_STARTEND: you are talking about > > > apples and oranges here. NO_REGEX is a Makefile flag, while REG_STARTEND > > > is a C preprocessor macro. > > > > > > Unless you can convince the rest of the Git developers (you would not > > > convince me) to simulate autoconf by compiling an executable every time > > > `make` is run, to determine whether REG_STARTEND is defined, this is a > > > no-go. > > > > But just to clarify, does anyone have any objection to making our > > configure.ac compile a C program to check for this sort of thing? > > Because that seems like the easiest solution to this class of problem. > > No, I think that is the exact purpose of configure.ac and autoconf. > > It would be neat if we could auto-fallback during the build. Rich > suggested always compiling compat/regex.c, and just having it be a noop > at the preprocessor level. I'm not sure if that would work, though, > because we'd have to include the system "regex.h" to know if we have > REG_STARTEND, at which point it is potentially too late to compile our > own regex routines (we're potentially going to conflict with the system > declarations). If you have autoconf testing for REG_STARTEND at configure time then compat/regex.c can #include "config.h" and test for HAVE_REG_STARTEND rather than for REG_STARTEND, or something like that. Rich