From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 4E4631F4F8 for ; Wed, 5 Oct 2016 16:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968AbcJEQ2A (ORCPT ); Wed, 5 Oct 2016 12:28:00 -0400 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:55572 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbcJEQ17 (ORCPT ); Wed, 5 Oct 2016 12:27:59 -0400 Received: from dalias by brightrain.aerifal.cx with local (Exim 3.15 #2) id 1brp2V-0007pS-00; Wed, 05 Oct 2016 16:27:27 +0000 Date: Wed, 5 Oct 2016 12:27:27 -0400 From: Rich Felker To: Jeff King Cc: James B , Johannes Schindelin , musl@lists.openwall.com, git@vger.kernel.org Subject: Re: [musl] Re: Regression: git no longer works with musl libc's regex impl Message-ID: <20161005162727.GK19318@brightrain.aerifal.cx> References: <20161004150848.GA7949@brightrain.aerifal.cx> <20161004152722.ex2nox43oj5ak4yi@sigill.intra.peff.net> <20161004154045.GT19318@brightrain.aerifal.cx> <20161005090625.683fdbbfac8164125dee6469@gmail.com> <20161005225934.770d73b7d491d4bf4816411d@gmail.com> <20161005161158.62o7qmpwxdgf6zzk@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161005161158.62o7qmpwxdgf6zzk@sigill.intra.peff.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Oct 05, 2016 at 12:11:58PM -0400, Jeff King wrote: > On Wed, Oct 05, 2016 at 10:59:34PM +1100, James B wrote: > > > Number downloads does not make first-tier platform. You know that as > > well as everyone else. > > > > First-tier support is the decision made by the maintainers that the > > entire features of the software must be available on those first tier > > platforms. So if Windows is indeed first-tier platform for git, it > > means any features that don't work on git version of Windows must not > > be used/developed or even castrated. That's a scary thought. > > Prepare to be scared, then, I guess. Ever since the msysgit project > started years ago, we have made concessions in the code to work both > with POSIX-ish systems and with the msys layer. E.g., see how git-daemon > does not fork(), but actually re-spawns itself to handle connections. > > When possible we try to put our abstractions at a level where they can > be implemented in a performant way on all platforms (the git-daemon > things is probably the _most_ ugly in that respect; I think nobody has > really cared about the performance enough to add back in a forking code > path for POSIX systems). > > > So this decision that "Windows is now a first-tier platform for git" - > > is your own opinion, or is this the collective opinion of *all* the > > git maintainers? > > There is only one maintainer of git: Junio. However, you'll note that I > also used "we" in the paragraphs above. And that is because the approach > I am talking about is something that has been done over the course of > many years by many members of the development community. > > You may disagree with that approach, but it is nothing new. The msysgit > project started in 2007. The goal of the midipix project is to make the need for FOSS projects supporting Windows to do hacks like this obsolete. It still has a little ways to go to be ready for mainstream use, but it's already running a lot, and I hope you'll consider it for the future since it simplifies things A LOT when you can just write to POSIX instead of having to come up with abstraction layers that cater to Windows' brokenness. > > Well thank you for being honest. I can see now why you responded the > > way you did (and still do). By being employed by Microsoft, and > > especially paid to work on Git for Windows, you have all the > > incentives to make it work best on Windows, and to make it as its > > first-tier platform within the limitation of Windows. > > Please don't insinuate that Johannes is a Microsoft shill. He has been > working on the Windows port of Git for over 9 years, and was only > employed by Microsoft this year. Furthermore, his original REG_STARTEND > patch actually did a run-time fallback of NUL-terminating the input > buffers. It was _I_ who suggested that we should simply push people > towards our compat/regex routines instead. So if you want to be mad at > somebody, be mad at me. I hope we can get this thread away from accusing and attacking people and on to doing productive things to make the software better. Rich