From: Josh Triplett <josh@joshtriplett.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/2] format-patch: Add a config option format.from to set the default for --from
Date: Sun, 7 Aug 2016 19:02:18 -1000 [thread overview]
Message-ID: <20160808050217.u2pmbu7b7yww4viv@x> (raw)
In-Reply-To: <20160808045441.duy7ztgdrz7wpvzj@sigill.intra.peff.net>
On Mon, Aug 08, 2016 at 12:54:41AM -0400, Jeff King wrote:
> On Sun, Aug 07, 2016 at 06:42:07PM -1000, Josh Triplett wrote:
>
> > > Drop trailing comma after the last enum definition (trailing comma
> > > after the last element in an array is OK, though).
> >
> > I realize this code didn't get included in the final version, but for
> > future reference, what's the rationale for this? I tend to include a
> > final comma in cases like these (and likewise for initializers) to avoid
> > needing to change the last line when introducing a new element, reducing
> > noise in diffs. I hadn't seen anything in any of the coding style
> > documentation talking about trailing commas (either pro or con).
>
> Portability; some compilers choke on it. C89 allows trailing commas in
> array initialization but _not_ in enums. Most compilers allow it anyway
> (though gcc complains with -Wpedantic).
>
> This definitely broke the build on real systems early in Git's history
> (I think the AIX compiler was one culprit),
Thanks for the explanation. I assume such compilers also don't accept
C99?
> but at this point it's
> possible that all of those compilers have died off. It would be nice if
> we could start using it (for exactly the reasons you give).
> Unfortunately there's not a good way to know except "introduce it and
> see if people complain".
Fair enough. I'll let someone else be the test case for that. :)
Perhaps the next Git user survey could ask "what compiler (including
version) do you use to compile Git", and perhaps "does it accept the
following code:"?
- Josh Triplett
next prev parent reply other threads:[~2016-08-08 5:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.4d006cadf197f80d899ad7d7d56d8ba41f574adf.1469905775.git-series.josh@joshtriplett.org>
2016-07-30 19:11 ` [PATCH v2 1/2] format-patch: Add a config option format.from to set the default for --from Josh Triplett
2016-08-01 17:38 ` Jeff King
2016-08-07 22:57 ` Josh Triplett
2016-08-08 1:59 ` Junio C Hamano
2016-08-08 4:34 ` Josh Triplett
2016-08-08 18:01 ` Junio C Hamano
2016-08-01 21:18 ` Junio C Hamano
2016-08-08 4:42 ` Josh Triplett
2016-08-08 4:54 ` Jeff King
2016-08-08 5:02 ` Josh Triplett [this message]
2016-08-08 5:06 ` Jeff King
2016-07-30 19:11 ` [PATCH v2 2/2] format-patch: Default to --from Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808050217.u2pmbu7b7yww4viv@x \
--to=josh@joshtriplett.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).