From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: santiago@nyu.edu, Git Mailing List <git@vger.kernel.org>,
Eric Sunshine <sunshine@sunshineco.com>,
Colin Walters <walters@verbum.org>
Subject: Re: [RFC/PATCH] verify-tag: add --check-name flag
Date: Tue, 7 Jun 2016 18:29:09 -0400 [thread overview]
Message-ID: <20160607222908.GA25631@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqk2i0od1f.fsf@gitster.mtv.corp.google.com>
On Tue, Jun 07, 2016 at 03:21:48PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > If you are suggesting that you can do the whole thing today by parsing
> > the tag object yourself, then sure, I agree. I thought the point of the
> > exercise was to make that less painful for the callers.
>
> Yes, and I somehow thought everybody agreed that --show-tag-name was
> striking the balance at about the right level for ease-of-use and
> simplicity?
No, I think "--format" would be much better, unless you want to add a
separate "--show-tagger-ident" when somebody wants to do a check between
the tagger's ident and the key uid.
But either way, I think the whole "do a rev-parse first" thing raises
the question of what object identifiers "git tag" would accept. We would
presumably expect:
git tag --show-tag-name v1.0
to work. And I think in your world-view, so would:
git tag --show-tag-name $(git rev-parse v1.0)
How about:
git tag --show-tag-name refs/tags/v1.0
And what about:
git tag --show-tag-name refs/remotes/foo/v1.0
or even:
git tag --show-tag-name foo/v1.0
when refs/remotes/foo/v1.0 exists?
The rule right now is generally that "git tag" takes actual tag names.
Plumbing like "verify-tag" takes arbitrary get_sha1() expressions, but
you're expected to qualify or resolve your refnames before you get
there, to avoid weird situations. This "tag --show-tag-name" seems to
sit in the middle of plumbing and porcelain (for that matter, I am not
sure that it should belong to git-tag at all, as it is really about
scripting).
-Peff
next prev parent reply other threads:[~2016-06-07 22:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 19:56 [RFC/PATCH] verify-tag: add --check-name flag santiago
2016-06-07 21:05 ` Junio C Hamano
2016-06-07 21:17 ` Jeff King
2016-06-07 21:30 ` Santiago Torres
2016-06-07 21:50 ` Junio C Hamano
2016-06-07 21:55 ` Jeff King
2016-06-07 22:05 ` Junio C Hamano
2016-06-07 22:07 ` Jeff King
2016-06-07 22:11 ` Junio C Hamano
2016-06-07 22:13 ` Jeff King
2016-06-07 22:16 ` Santiago Torres
2016-06-07 22:21 ` Junio C Hamano
2016-06-07 22:29 ` Jeff King [this message]
2016-06-07 22:35 ` Junio C Hamano
2016-06-08 14:21 ` Santiago Torres
2016-06-08 18:43 ` Junio C Hamano
2016-06-09 11:48 ` Michael J Gruber
2016-06-07 21:20 ` Santiago Torres
2016-06-07 21:08 ` Jeff King
2016-06-07 21:13 ` Santiago Torres
2016-06-07 21:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607222908.GA25631@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=santiago@nyu.edu \
--cc=sunshine@sunshineco.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).