From: Jeff King <peff@peff.net>
To: Santiago Torres <santiago@nyu.edu>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Colin Walters <walters@verbum.org>
Subject: Re: [RFC/PATCH] verify-tag: add --check-name flag
Date: Tue, 7 Jun 2016 17:18:45 -0400 [thread overview]
Message-ID: <20160607211845.GA7696@sigill.intra.peff.net> (raw)
In-Reply-To: <20160607211313.GD24676@LykOS.localdomain>
On Tue, Jun 07, 2016 at 05:13:14PM -0400, Santiago Torres wrote:
> > 2. What do we do for non-annotated tags? Is it always a failure?
>
> Right now, verify-tag fails with non-annotated tags like this:
>
> santiago at ~/.../git ✔ ./git-verify-tag master
> error: master: cannot verify a non-tag object of type commit.
>
> Although we could change this behavior. I would have to check how git
> tag -v works as this behavior might change.
Oh, right. That makes sense. I think it's not worth worrying about that
case, then.
-Peff
prev parent reply other threads:[~2016-06-07 21:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 19:56 [RFC/PATCH] verify-tag: add --check-name flag santiago
2016-06-07 21:05 ` Junio C Hamano
2016-06-07 21:17 ` Jeff King
2016-06-07 21:30 ` Santiago Torres
2016-06-07 21:50 ` Junio C Hamano
2016-06-07 21:55 ` Jeff King
2016-06-07 22:05 ` Junio C Hamano
2016-06-07 22:07 ` Jeff King
2016-06-07 22:11 ` Junio C Hamano
2016-06-07 22:13 ` Jeff King
2016-06-07 22:16 ` Santiago Torres
2016-06-07 22:21 ` Junio C Hamano
2016-06-07 22:29 ` Jeff King
2016-06-07 22:35 ` Junio C Hamano
2016-06-08 14:21 ` Santiago Torres
2016-06-08 18:43 ` Junio C Hamano
2016-06-09 11:48 ` Michael J Gruber
2016-06-07 21:20 ` Santiago Torres
2016-06-07 21:08 ` Jeff King
2016-06-07 21:13 ` Santiago Torres
2016-06-07 21:18 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607211845.GA7696@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=santiago@nyu.edu \
--cc=sunshine@sunshineco.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).