From: Jeff King <peff@peff.net>
To: Per Cederqvist <cederp@opera.com>
Cc: git@vger.kernel.org
Subject: Re: "git branch --contains x y" creates a branch instead of checking containment
Date: Thu, 21 Feb 2013 10:58:28 -0500 [thread overview]
Message-ID: <20130221155827.GA20640@sigill.intra.peff.net> (raw)
In-Reply-To: <51261A6B.5020909@opera.com>
On Thu, Feb 21, 2013 at 02:00:27PM +0100, Per Cederqvist wrote:
> That command does something completely different,
> though. The "--contains x" part is silently ignored,
> so it creates a branch named "y" pointing at HEAD.
>
> Tested in git 1.8.1.1 and 1.8.1.4.
>
> In my opinion, there are two ways to fix this:
>
> - change the "git branch" implementation so
> that --contains implies --list.
I think that is the best option, too. In fact, I even wrote a patch. :)
It's d040350 (branch: let branch filters imply --list, 2013-01-31), and
it's already in v1.8.2-rc0.
-Peff
next prev parent reply other threads:[~2013-02-21 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 13:00 "git branch --contains x y" creates a branch instead of checking containment Per Cederqvist
2013-02-21 15:58 ` Jeff King [this message]
2013-02-21 16:05 ` Per Cederqvist
2013-02-21 17:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221155827.GA20640@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=cederp@opera.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).