From: Michal Vyskocil <mvyskocil@suse.cz>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] show git tag output in pager
Date: Thu, 29 Sep 2011 11:37:49 +0200 [thread overview]
Message-ID: <20110929093749.GB27152@zelva.suse.cz> (raw)
In-Reply-To: <vpqehz2cbk4.fsf@bauges.imag.fr>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Tue, Sep 27, 2011 at 04:19:39PM +0200, Matthieu Moy wrote:
> The commit message should explain why this is needed, and in particular
> why you prefer this to setting pager.tag in your ~/.gitconfig.
Opps! I read a documentation, but I did not realize this works for all
commands and not only for them calling setup_pager(). Then sorry, no
change is needed.
>
> Michal Vyskocil <mvyskocil@suse.cz> writes:
>
> > --- a/builtin/tag.c
> > +++ b/builtin/tag.c
> > @@ -147,6 +147,8 @@ static int list_tags(const char **patterns, int lines,
> > struct commit_list *with_commit)
> > {
> > struct tag_filter filter;
> > +
> > + setup_pager();
>
> Git indents with tabs, not spaces, and does not leave trailing
> whitespaces.
OK, thanks for the feedbac. I will try to be more carefull in the
future.
Regards
Michal Vyskocil
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-09-29 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 13:42 [PATCH] show git tag output in pager Michal Vyskocil
2011-09-27 14:19 ` Matthieu Moy
2011-09-29 9:37 ` Michal Vyskocil [this message]
2011-09-30 10:42 ` Jeff King
2011-10-03 12:57 ` Matthieu Moy
2011-10-07 14:44 ` Jeff King
2011-10-07 14:48 ` Matthieu Moy
2011-10-07 16:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929093749.GB27152@zelva.suse.cz \
--to=mvyskocil@suse.cz \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).