From: Clemens Buchacher <drizzd@aon.at>
To: git@vger.kernel.org
Cc: msysgit@googlegroups.com, Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: [PATCH] git-gui: suggest gc only when counting at least 2 objects
Date: Sun, 13 Sep 2009 18:06:37 +0200 [thread overview]
Message-ID: <20090913160637.GA15256@localhost> (raw)
In-Reply-To: <20090909195158.GA12968@localhost>
On Windows, git-gui suggests running the garbage collector if it finds
1 or more files in .git/objects/42 (as opposed to 8 files on other
platforms). The probability of that happening if the repo contains
only about 100 loose objects is 32%. The probability for the same to happen
with at least 2 files is only 6%, which is bit more reasonable.
The following octave script shows the probability for m or more
objects to be in .git/objects/42 for a total of n objects.
m = [1 2 8];
n = 100:100:3000;
P = zeros(length(n), length(m));
for k = 1:length(n)
P(k, :) = 1-binocdf(m-1, n(k), 1/255);
end
plot(n, P);
n \ m 1 2 8
100 32% 6% 0%
500 86% 58% 0%
1000 98% 90% 5%
2000 100% 100% 55%
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
So here is the patch for my other complaint. Note that I fixed a bug in the
octave script above, in case someone wants to check the numbers.
I even tested it on a windows VM (as if it wasn't slow enough already).
Clemens
git-gui/lib/database.tcl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/lib/database.tcl b/git-gui/lib/database.tcl
index a18ac8b..44099e5 100644
--- a/git-gui/lib/database.tcl
+++ b/git-gui/lib/database.tcl
@@ -91,7 +91,7 @@ proc do_fsck_objects {} {
proc hint_gc {} {
set object_limit 8
if {[is_Windows]} {
- set object_limit 1
+ set object_limit 2
}
set objects_current [llength [glob \
--
1.6.5.rc0.164.g5f6b0
next prev parent reply other threads:[~2009-09-13 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 19:51 [PATCH] preserve mtime of local clone Clemens Buchacher
2009-09-12 5:09 ` Junio C Hamano
2009-09-12 8:26 ` Clemens Buchacher
2009-09-12 9:03 ` Clemens Buchacher
2009-09-13 3:06 ` Junio C Hamano
2009-09-13 10:49 ` [PATCH v3] " Clemens Buchacher
2009-09-13 16:06 ` Clemens Buchacher [this message]
2009-09-13 17:58 ` [PATCH] git-gui: suggest gc only when counting at least 2 objects Junio C Hamano
2009-09-13 18:41 ` Clemens Buchacher
2009-09-13 20:44 ` Jeff King
2009-09-13 21:19 ` Clemens Buchacher
2009-09-13 22:20 ` [PATCH] git-gui: search 4 directories to improve statistic of gc hint Clemens Buchacher
2009-09-14 3:39 ` [PATCH] git-gui: suggest gc only when counting at least 2 objects Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090913160637.GA15256@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).