From: Miklos Vajna <vmiklos@frugalware.org>
To: Robert Schiele <rschiele@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: improve customization for supporting HP-UX
Date: Sun, 24 Aug 2008 00:03:58 +0200 [thread overview]
Message-ID: <20080823220358.GH23800@genesis.frugalware.org> (raw)
In-Reply-To: <20080823210243.GB7185@schiele.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]
On Sat, Aug 23, 2008 at 11:02:43PM +0200, Robert Schiele <rschiele@gmail.com> wrote:
> On Sat, Aug 23, 2008 at 10:26:01PM +0200, Miklos Vajna wrote:
> > On Sat, Aug 23, 2008 at 10:09:28PM +0200, Robert Schiele <rschiele@gmail.com> wrote:
> > > The systems I build on are:
> > >
> > > 1x HP-UX B.11.11 U 9000/785
> >
> > This is the same version I'm using at the moment.
> >
> > The NEEDS_LIBICONV is simple, the linker fails to find iconv symbols:
> >
> > /usr/ccs/bin/ld: Unsatisfied symbols:
> > libiconv (first referenced in libgit.a(utf8.o)) (code)
> > libiconv_open (first referenced in libgit.a(utf8.o)) (code)
> > libiconv_close (first referenced in libgit.a(utf8.o)) (code)
> > collect2: ld returned 1 exit status
> > gmake: *** [git] Error 1
>
> Huh? Where does the "lib" prefix come from on your system? Do you have some
> custom iconv header file in the way? On my system I see:
>
> [13] % nm /usr/lib/libc.2 | grep ^iconv
> iconv | 1255080|extern|entry |
> iconv | 1255112|extern|code |$CODE$
> iconv_close | 1254800|extern|entry |
> iconv_close | 1254832|extern|code |$CODE$
> iconv_open | 1255208|extern|entry |
> iconv_open | 1255272|extern|code |$CODE$
> [14] %
Ah, OK, that is specific to this machine. If you install the libiconv
package, then #include <iconv.h> includes /usr/local/include/iconv.h
where iconv is a define to libiconv. So that is not needed generally,
thanks for pointing out.
> Thus I think the snprintf part of your patch makes sense but the iconv stuff
> seems to be something flawed on your machine.
OK, I'll send a patch with that part only in a bit.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-08-23 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 19:41 [PATCH] Makefile: improve customization for supporting HP-UX Miklos Vajna
2008-08-23 20:09 ` Robert Schiele
2008-08-23 20:26 ` Miklos Vajna
2008-08-23 21:02 ` Robert Schiele
2008-08-23 22:03 ` Miklos Vajna [this message]
2008-08-23 22:07 ` [PATCH] Makefile: enable SNPRINTF_RETURNS_BOGUS for HP-UX Miklos Vajna
2008-08-24 1:00 ` Junio C Hamano
2008-08-24 4:33 ` Robert Schiele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080823220358.GH23800@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=git@vger.kernel.org \
--cc=rschiele@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).