From: "Karl Hasselström" <kha@treskal.com>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [StGIT PATCH 3/4] Convert git_id() to the new id format
Date: Sun, 22 Jun 2008 17:48:54 +0200 [thread overview]
Message-ID: <20080622154854.GC4468@diana.vm.bytemark.co.uk> (raw)
In-Reply-To: <20080619214222.27794.74083.stgit@localhost.localdomain>
On 2008-06-19 22:42:22 +0100, Catalin Marinas wrote:
> The patch rewrites git_id() to use the new id format and coverts the
> commands using this function. The git_id() will be removed once all
> the commands are converted to the new infrastructure where
> git_commit() will be used instead.
Looks good. And the code volume reduction is significant.
> if not rev:
> + # backwards compatibility
> return None
Could you expand this comment a bit? It's not enough of a clue for me.
:-/
> -def git_commit(name, repository, branch = None):
> +def git_commit(name, repository, branch_name = None):
Very nice parameter rename here, now that we have Branch objects (and
use a crappy language with no type system).
> -rev = '([patch][//[bottom | top]]) | <tree-ish> | base'
> -
> -If neither bottom nor top are given but a '//' is present, the command
> -shows the specified patch (defaulting to the current one)."""
> +rev = '([branch:]patch) | <tree-ish> | base'
You can remove the parentheses now; they were only needed because they
used to enclose a complicated expression. Besides, shouldn't it be
[branch:]{base} instead of base? So something like
rev = [<branch>:]<patch> | [<branch>:]{base} | <tree-ish>
> help = 'show the files modified by a patch (or the current patch)'
> -usage = """%prog [options] [<patch>]
> +usage = """%prog [options] [[<branch>:]<patch>]
Unrelated to this patch: I realized last week that it's silly for stg
files to not accept a patch range.
> if len(args) == 0:
> - patch = ''
> + patch = 'HEAD'
Ah, so this is the backwards compatibility thing -- we used to pass
the empty string when we meant HEAD.
> - (refpatchname, refbranchname, refpatchid) = parse_rev(patchname)
> - if refpatchname and not refpatchid and \
> - (not refpatchid or refpatchid == 'top'):
> - # FIXME: should also support picking //top.old
> + refbranchname, refpatchname = parse_rev(patchname)
> + if refpatchname:
The corresponding TODO comment now would be that pick should be able
to pick patches from the past, from the stack log.
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle
next prev parent reply other threads:[~2008-06-22 15:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 21:41 [StGIT PATCH 0/4] Proposed patches Catalin Marinas
2008-06-19 21:42 ` [StGIT PATCH 1/4] Allow e-mails to be sent with the Unix sendmail tool Catalin Marinas
2008-06-22 15:10 ` Karl Hasselström
2008-06-29 21:55 ` Catalin Marinas
2008-06-19 21:42 ` [StGIT PATCH 2/4] Implement a new patch identification scheme and id command Catalin Marinas
2008-06-22 15:27 ` Karl Hasselström
2008-06-19 21:42 ` [StGIT PATCH 3/4] Convert git_id() to the new id format Catalin Marinas
2008-06-22 15:48 ` Karl Hasselström [this message]
2008-07-13 11:20 ` Catalin Marinas
2008-07-14 6:44 ` Karl Hasselström
2008-06-19 21:42 ` [StGIT PATCH 4/4] Remove the applied/unapplied commands Catalin Marinas
2008-06-22 16:13 ` Karl Hasselström
2008-07-13 11:31 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080622154854.GC4468@diana.vm.bytemark.co.uk \
--to=kha@treskal.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).