From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] fast-import: use binary search in tree_content_remove
Date: Mon, 12 Mar 2007 15:13:13 -0400 [thread overview]
Message-ID: <20070312191313.GC15887@spearce.org> (raw)
In-Reply-To: <20070311163412.GB7110@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> And here is a test that I believe triggers the problem (fails with my
> patches, succeeds with your fix):
Thanks, this is a good test to have. Since the current "stable"
version passes without your patches I'm applying the test first;
that way we can see if/when a change breaks this ordering requirement
and address it immediately in that patch.
> > I'm plastering over the problem by resorting a tree strictly by
> > name after it has been written out and the deleted entries have
> > been filtered out.
>
> I wonder if we could make this a bit cleaner by actually using the git
> sort in the first place. I will take a look...
Good luck. I'm not sure its easily done. Which is why I'm not
attempting to do it right now.
--
Shawn.
prev parent reply other threads:[~2007-03-12 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<20070310191515.GA3416@coredump.intra.peff.net>
2007-03-10 19:16 ` [PATCH 1/3] fast-import: grow tree storage more aggressively Jeff King
2007-03-10 19:21 ` [PATCH 2/3] fast-import: tree allocation cleanups Jeff King
2007-03-11 3:21 ` Shawn O. Pearce
2007-03-11 15:51 ` Jeff King
2007-03-11 15:59 ` Jeff King
2007-03-12 19:16 ` Shawn O. Pearce
2007-03-10 19:21 ` [PATCH 3/3] fast-import: improve efficiency of tree_content_set Jeff King
2007-03-10 19:23 ` Jeff King
2007-03-10 19:40 ` [PATCH] fast-import: use binary search in tree_content_remove Jeff King
2007-03-11 3:38 ` Shawn O. Pearce
2007-03-11 16:34 ` Jeff King
2007-03-11 16:54 ` Jeff King
2007-03-11 20:19 ` Shawn O. Pearce
2007-03-12 19:13 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312191313.GC15887@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).