From: Dragan Simic <dsimic@manjaro.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>,
Eric Sunshine <sunshine@sunshineco.com>,
Phillip Wood <phillip.wood123@gmail.com>,
Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org, Drew DeVault <sir@cmpwn.com>
Subject: Re: [PATCH] format-patch: ensure that --rfc and -k are mutually exclusive
Date: Sun, 21 Apr 2024 16:00:57 +0200 [thread overview]
Message-ID: <1d7ee11f801f2754529256bbf4570fd3@manjaro.org> (raw)
In-Reply-To: <xmqqo7a5mk8f.fsf@gitster.g>
On 2024-04-19 17:43, Junio C Hamano wrote:
> "Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
>
>> On Fri, Apr 19, 2024, at 03:05, Dragan Simic wrote:
>>> Fix a bug that allows the "--rfc" and "-k" options to be specified
>>> together
>>> when "git format-patch" is executed, which was introduced in the
>>> commit
>>> e0d7db7423a9 ("format-patch: --rfc honors what --subject-prefix
>>> sets").
>>>
>>> Add a couple of additional tests to t4014, to cover additional cases
>>> of
>>> the mutual exclusivity between different "git format-patch" options.
>>>
>>> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
>>
>> Looks good to me FWIW. Also very good description of the changes from
>> the previous version to this one.
>
> Yup, very easy to follow what changed and how.
>
> Will queue, thanks all.
Thank you!
next prev parent reply other threads:[~2024-04-21 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 1:05 [PATCH] format-patch: ensure that --rfc and -k are mutually exclusive Dragan Simic
2024-04-19 2:58 ` Dragan Simic
2024-04-19 8:51 ` Drew DeVault
2024-04-19 9:30 ` Dragan Simic
2024-04-19 13:43 ` Kristoffer Haugsbakk
2024-04-19 15:43 ` Junio C Hamano
2024-04-21 14:00 ` Dragan Simic [this message]
2024-04-21 13:50 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d7ee11f801f2754529256bbf4570fd3@manjaro.org \
--to=dsimic@manjaro.org \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=sir@cmpwn.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).