From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 442851F990 for ; Tue, 4 Aug 2020 13:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728170AbgHDNDu (ORCPT ); Tue, 4 Aug 2020 09:03:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728190AbgHDNDl (ORCPT ); Tue, 4 Aug 2020 09:03:41 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 105D7C06174A for ; Tue, 4 Aug 2020 06:03:38 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id s23so30744706qtq.12 for ; Tue, 04 Aug 2020 06:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UKB9eT/XOdSekN/p4PkVrEky3DroWOFuM9Rwun3z7lA=; b=j2njcow8b1j3+wXSTF56Yi9cFK5PZB2iun+LqwtigqLLdhZ9ECEBPiu6H9xrOPZorQ YecNXZ6kOPAD5ifYkhTkT5OD2OWUqzAhSyon3dixDieYxHDwJxK61mFITPPntxYGhDvS 6HngINcof6oXe75XmIekZW+Yvyz57fNRVIlWOBq1iMpoXSUTNjZ0AR9XlaFW1Ee/PK0d ZL1BeiGq0iiKDSuV7RPPvkCW/qre8c21BXQb+j/wqWloZinFlspMp3XC6kmMPVdraEiU hTR1vhPdI1Sa8ESl8VcQeREYdUfUpoX2N6/JhEGub70sXVKSwtUbqK7hZGrkp6yGL2h2 ntog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UKB9eT/XOdSekN/p4PkVrEky3DroWOFuM9Rwun3z7lA=; b=W656luHC0kODkRHi2LxDDcWwAPzzcCazi5FeWTiy1xe6pkbDTQsO3/9WSqPAl6GHhq mbsaEwNqnRy/1p6dpu4gvwZ0pO4CBiAVfZcouzWEzBvGhX+D3e8BjopaKXBErOpwY7xK +oNKzrEaXDVXYb3URALfJzE8p7TcR7Bo11dp+TB1KXveHUPdIwj7GccjcHMHUy45Rfol SmGoyKoQNiSiNAnaDzUIA9LSWX7by8anleiRvWaG0Zlqrk7Z6KCCD0zQS2MbkYWbqO1o g+pEUszo9z9JKtvMEivZznDADk23A5zQVUJN5LUCU3GViLRcgB+QYEhuOIZneammDZhM V2Ww== X-Gm-Message-State: AOAM5321OS4pFb84KC1h0iWS+FlA18YStBOoSHnnqvgT3X1QEORZ8GcL REButguAOM4srHdJok5fRkY= X-Google-Smtp-Source: ABdhPJxTmlO2hmkQyMOGH6aWcMHieQKyT4RK15GpzXAPL927vV01QDvemoHXgzQygaTl/8winzEnCQ== X-Received: by 2002:ac8:4558:: with SMTP id z24mr22395250qtn.241.1596546217265; Tue, 04 Aug 2020 06:03:37 -0700 (PDT) Received: from ?IPv6:2600:1700:e72:80a0:359e:33e7:c1bc:799? ([2600:1700:e72:80a0:359e:33e7:c1bc:799]) by smtp.gmail.com with ESMTPSA id y50sm27191149qtk.29.2020.08.04.06.03.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2020 06:03:36 -0700 (PDT) Subject: Re: [PATCH 10/10] builtin/commit-graph.c: introduce '--max-new-filters=' To: Taylor Blau , git@vger.kernel.org Cc: peff@peff.net, dstolee@microsoft.com References: <8b670571dc24973cc5e894b866a68236d8fbfa4f.1596480582.git.me@ttaylorr.com> From: Derrick Stolee Message-ID: <1c2e841b-4b04-30ba-6c94-96f8bf0cf449@gmail.com> Date: Tue, 4 Aug 2020 09:03:36 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <8b670571dc24973cc5e894b866a68236d8fbfa4f.1596480582.git.me@ttaylorr.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 8/3/2020 2:57 PM, Taylor Blau wrote: > Introduce a command-line flag and configuration variable to fill in the > 'max_new_filters' variable introduced by the previous patch. > > The command-line option '--max-new-filters' takes precedence over > 'graph.maxNewFilters', which is the default value. commitGraph.maxNewFilters? > '--no-max-new-filters' can also be provided, which sets the value back > to '-1', indicating that an unlimited number of new Bloom filters may be > generated. (OPT_INTEGER only allows setting the '--no-' variant back to > '0', hence a custom callback was used instead). Other than the commit message typo above, this is a good patch. Thanks, -Stolee