From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH v2] travis-ci: retry if Git for Windows CI returns HTTP error 502 or 503
Date: Tue, 9 May 2017 18:40:01 +0100 [thread overview]
Message-ID: <1ADD08FD-1DC0-4AC5-9E69-AC1A5DCBED83@gmail.com> (raw)
In-Reply-To: <xmqqpofi35ik.fsf@gitster.mtv.corp.google.com>
> On 09 May 2017, at 07:31, Junio C Hamano <gitster@pobox.com> wrote:
>
> Lars Schneider <larsxschneider@gmail.com> writes:
>
>> The Git for Windows CI web app sometimes returns HTTP errors of
>> "502 bad gateway" or "503 service unavailable" [1]. We also need to
>> check the HTTP content because the GfW web app seems to pass through
>> (error) results from other Azure calls with HTTP code 200.
>> Wait a little and retry the request if this happens.
>>
>> [1] https://docs.microsoft.com/en-in/azure/app-service-web/app-service-web-troubleshoot-http-502-http-503
>>
>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
>> ---
>>
>> Hi Junio,
>>
>> I can't really test this as my TravisCI account does not have the
>> extended timeout and I am unable to reproduce the error.
>>
>> It would be great if we could test this is a little bit in pu.
>
> This has been in 'pu' for a while.
>
> As the patch simply discards 502 (and others), it is unclear if the
> failing test on 'next' is now gone, or the attempt to run 'pu'
> happened to be lucky not to get one, from the output we can see in
> https://travis-ci.org/git/git/jobs/229867212
>
> Are you comfortable enough to move this forward?
Yes, please move it forward. I haven't seen a "502 - Web server
received an invalid response" on pu for a while. That means the
patch should work as expected.
Unrelated to this patch I have, however, seen two kinds of timeouts:
(1) Timeout in the "notStarted" state. This job eventually finished
with a failure but it did start only *after* 3h:
https://travis-ci.org/git/git/jobs/230225611
(2) Timeout in the "in progress" state. This job eventually finished
successfully but it took longer than 3h:
https://travis-ci.org/git/git/jobs/229867248
Right now the timeout generates potential false negative results.
I would like to change that and respond with a successful build
*before* we approach the 3h timeout. This means we could generate
false positives. Although this is not ideal, I think that is the better
compromise as a failing Windows build would usually fail quickly
(e.g. in the compile step).
What do you guys think? Would you be OK with that reasoning?
If the Git for Windows builds get more stable over time then
we could reevaluate this compromise.
- Lars
next prev parent reply other threads:[~2017-05-09 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 21:50 [PATCH v2] travis-ci: retry if Git for Windows CI returns HTTP error 502 or 503 Lars Schneider
2017-05-04 9:19 ` Johannes Schindelin
2017-05-09 6:31 ` Junio C Hamano
2017-05-09 17:40 ` Lars Schneider [this message]
2017-05-09 23:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ADD08FD-1DC0-4AC5-9E69-AC1A5DCBED83@gmail.com \
--to=larsxschneider@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).