From: Matt McCutchen <matt@mattmccutchen.net>
To: Jeff King <peff@peff.net>
Cc: git <git@vger.kernel.org>
Subject: Re: Protecting old temporary objects being reused from concurrent "git gc"?
Date: Tue, 15 Nov 2016 14:12:52 -0500 [thread overview]
Message-ID: <1479237172.2406.91.camel@mattmccutchen.net> (raw)
In-Reply-To: <20161115174028.zvohfcw4jse3jrmm@sigill.intra.peff.net>
On Tue, 2016-11-15 at 12:40 -0500, Jeff King wrote:
> On Tue, Nov 15, 2016 at 12:33:04PM -0500, Matt McCutchen wrote:
>
> >
> > On Tue, 2016-11-15 at 12:06 -0500, Jeff King wrote:
> > >
> > > - when an object write is optimized out because we already have the
> > > object, git will update the mtime on the file (loose object or
> > > packfile) to freshen it
> >
> > FWIW, I am not seeing this happen when I do "git read-tree --prefix"
> > followed by "git write-tree" using the current master (3ab2281). See
> > the attached test script.
>
> The optimization I'm thinking about is the one from write_sha1_file(),
> which learned to freshen in 33d4221c7 (write_sha1_file: freshen existing
> objects, 2014-10-15).
>
> I suspect the issue is that read-tree populates the cache-tree index
> extension, and then write-tree omits the object write before it even
> gets to write_sha1_file(). The solution is that it should probably be
> calling one of the freshen() functions (possibly just replacing
> has_sha1_file() with check_and_freshen(), but I haven't looked).
>
> I'd definitely welcome patches in this area.
Cool, it's nice to have an idea of what's going on. I don't think I'm
going to try to fix it myself though.
By the way, thanks for the fast response to my original question!
Matt
next prev parent reply other threads:[~2016-11-15 19:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:13 Protecting old temporary objects being reused from concurrent "git gc"? Matt McCutchen
2016-11-15 17:06 ` Jeff King
2016-11-15 17:33 ` Matt McCutchen
2016-11-15 17:40 ` Jeff King
2016-11-15 19:08 ` [PATCH] git-gc.txt: expand discussion of races with other processes Matt McCutchen
2016-11-15 19:12 ` Matt McCutchen [this message]
2016-11-15 20:01 ` Protecting old temporary objects being reused from concurrent "git gc"? Junio C Hamano
2016-11-16 8:07 ` Jeff King
2016-11-16 18:18 ` Junio C Hamano
2016-11-16 18:58 ` Junio C Hamano
2016-11-17 1:04 ` Jeff King
2016-11-17 1:35 ` Re* " Junio C Hamano
2016-11-17 1:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479237172.2406.91.camel@mattmccutchen.net \
--to=matt@mattmccutchen.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).